Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753730AbaKEDNv (ORCPT ); Tue, 4 Nov 2014 22:13:51 -0500 Received: from mail-qa0-f50.google.com ([209.85.216.50]:59597 "EHLO mail-qa0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752400AbaKEDNt (ORCPT ); Tue, 4 Nov 2014 22:13:49 -0500 Date: Tue, 4 Nov 2014 22:13:45 -0500 From: Tejun Heo To: Yijing Wang Cc: Weng Meiling , Greg KH , Frans Klaver , Jens Axboe , akpm@linux-foundation.org, adilger.kernel@dilger.ca, Jan Kara , "linux-kernel@vger.kernel.org" , Xiang Rui , Li Zefan , Huang Qiang , Zhao Hongjiang Subject: Re: Subject: [PATCH] kobject: fix the race between kobject_del and get_device_parent Message-ID: <20141105031345.GA29392@htj.dyndns.org> References: <543E1754.8040701@huawei.com> <543F25D3.8010708@huawei.com> <543F7289.8010807@huawei.com> <20141016091328.GB24374@kroah.com> <544765D0.70302@huawei.com> <20141104191535.GI14459@htj.dyndns.org> <54598503.1060905@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <54598503.1060905@huawei.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Wed, Nov 05, 2014 at 10:01:39AM +0800, Yijing Wang wrote: > > So, yeah, this looks like a correct approach; however, do we even need > > to clear the glue directories? > > Yes. In our platform, the glue directories > /sys/devices/virtual/block will be removed once the last child > device call device_del(). What I mean is why are we even trying to remove the parent directory? Can't we just keep them around once created? Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/