Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753253AbaKEDzn (ORCPT ); Tue, 4 Nov 2014 22:55:43 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:43087 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752039AbaKEDzl (ORCPT ); Tue, 4 Nov 2014 22:55:41 -0500 Date: Wed, 5 Nov 2014 03:55:36 +0000 From: Al Viro To: David Miller Cc: herbert@gondor.apana.org.au, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcrl@kvack.org Subject: Re: [PATCH 1/4] inet: Add skb_copy_datagram_iter Message-ID: <20141105035536.GO7996@ZenIV.linux.org.uk> References: <20141104144258.GA14743@gondor.apana.org.au> <20141104151353.GG7996@ZenIV.linux.org.uk> <20141105022251.GA19136@gondor.apana.org.au> <20141104.222727.275422581392488793.davem@davemloft.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141104.222727.275422581392488793.davem@davemloft.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2014 at 10:27:27PM -0500, David Miller wrote: > Al, is this the helper you are talking about? Mostly, except that I kept it 4-argument (and used skb_copy_datagram_msg() for name). Matter of taste - the ones you've missed because of that are net/appletalk/ddp.c:1761: err = skb_copy_datagram_iovec(skb, offset, msg->msg_iov, copied); net/ipv4/tcp.c:1836: err = skb_copy_datagram_iovec(skb, offset, net/ipv4/udp.c:1284: err = skb_copy_datagram_iovec(skb, sizeof(struct udphdr), net/ipv6/udp.c:427: err = skb_copy_datagram_iovec(skb, sizeof(struct udphdr), net/ipx/af_ipx.c:1808: rc = skb_copy_datagram_iovec(skb, sizeof(struct ipxhdr), msg->msg_iov, net/iucv/af_iucv.c:1358: if (skb_copy_datagram_iovec(cskb, offset, msg->msg_iov, copied)) { net/llc/af_llc.c:822: int rc = skb_copy_datagram_iovec(skb, offset, net/rxrpc/ar-recvmsg.c:183: ret = skb_copy_datagram_iovec(skb, offset, msg->msg_iov, copy); net/tipc/socket.c:1375: res = skb_copy_datagram_iovec(buf, msg_hdr_sz(msg), net/tipc/socket.c:1476: res = skb_copy_datagram_iovec(buf, msg_hdr_sz(msg) + offset, net/unix/af_unix.c:1828: err = skb_copy_datagram_iovec(skb, skip, msg->msg_iov, size); net/unix/af_unix.c:2033: if (skb_copy_datagram_iovec(skb, UNIXCB(skb).consumed + skip, net/vmw_vsock/vmci_transport.c:1776: err = skb_copy_datagram_iovec(skb, sizeof(*dg), msg->msg_iov, and back then I decided that 13 more converted instances might be worth keeping it in 4-argument form... What do you think of the trick with user_msghdr, BTW? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/