Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754053AbaKEIpS (ORCPT ); Wed, 5 Nov 2014 03:45:18 -0500 Received: from mail-wi0-f172.google.com ([209.85.212.172]:62741 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751408AbaKEIpO (ORCPT ); Wed, 5 Nov 2014 03:45:14 -0500 Date: Wed, 5 Nov 2014 10:45:04 +0200 From: Aya Mahfouz To: Sudip Mukherjee Cc: Jarod Wilson , Mauro Carvalho Chehab , Greg Kroah-Hartman , Dan Carpenter , Gulsah Kose , Tuomas Tynkkynen , Matina Maria Trompouki , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: lirc: replace dev_err by pr_err Message-ID: <20141105084504.GA2128@localhost.localdomain> References: <20141104001319.GA14567@localhost.localdomain> <20141104093653.GA3070@sudip-PC> <20141104214826.GA6793@localhost.localdomain> <20141105072738.GB4881@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141105072738.GB4881@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 05, 2014 at 12:57:38PM +0530, Sudip Mukherjee wrote: > On Tue, Nov 04, 2014 at 11:48:26PM +0200, Aya Mahfouz wrote: > > On Tue, Nov 04, 2014 at 03:06:53PM +0530, Sudip Mukherjee wrote: > > > On Tue, Nov 04, 2014 at 02:13:19AM +0200, Aya Mahfouz wrote: > > > > This patch replaces dev_err by pr_err since the value > > > > of ir is NULL when the message is displayed. > > > > > > > > Signed-off-by: Aya Mahfouz > > > > --- > > > > drivers/staging/media/lirc/lirc_zilog.c | 2 +- > > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c > > > > index 11a7cb1..ecdd71e 100644 > > > > --- a/drivers/staging/media/lirc/lirc_zilog.c > > > > +++ b/drivers/staging/media/lirc/lirc_zilog.c > > > > @@ -1633,7 +1633,7 @@ out_put_xx: > > > > out_put_ir: > > > > put_ir_device(ir, true); > > > > out_no_ir: > > > > - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n", > > > > + pr_err("%s: probing IR %s on %s (i2c-%d) failed with %d\n", > > > hi, > > > instead of ir->l.dev , can you please try dev_err like this : > > > > > > dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n", > > > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr, > > > ret); > > > > > > > Thanks Sudip. It works. Please add the Reviewed-by tag to the newer > > patch. > > > i think you forgot to add cc to the list and Greg K-H in your reply. > Greg should know that this patch is now not required, otherwise he might apply it to his tree. > so just replying to your mail while adding everyone else in the cc. > > thanks > sudip > > Apologies Sudip and thanks again! Kind Regards, Aya Saif El-yazal Mahfouz > > > thanks > > > sudip > > > > > > > Kind Regards, > > Aya Saif El-yazal Mahfouz > > > > > > > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr, > > > > ret); > > > > mutex_unlock(&ir_devices_lock); > > > > -- > > > > 1.9.3 > > > > > > > > -- > > > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > > > the body of a message to majordomo@vger.kernel.org > > > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/