Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754298AbaKEJQm (ORCPT ); Wed, 5 Nov 2014 04:16:42 -0500 Received: from mga01.intel.com ([192.55.52.88]:53525 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754081AbaKEJQ1 (ORCPT ); Wed, 5 Nov 2014 04:16:27 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,319,1413270000"; d="scan'208";a="626852182" Date: Wed, 5 Nov 2014 11:16:22 +0200 From: Mika Westerberg To: "Rafael J. Wysocki" Cc: Grant Likely , Darren Hart , Alexandre Courbot , Linus Walleij , Arnd Bergmann , ACPI Devel Mailing List , Linux Kernel Mailing List Subject: Re: [PATCH] ACPI / GPIO: Pass index to acpi_get_gpiod_by_index() when using properties Message-ID: <20141105091622.GW1618@lahna.fi.intel.com> References: <1414494927-204923-1-git-send-email-mika.westerberg@linux.intel.com> <2107668.8toVpPDgB1@vostro.rjw.lan> <3196606.Sy6xFg88zg@vostro.rjw.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3196606.Sy6xFg88zg@vostro.rjw.lan> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 04, 2014 at 11:54:41PM +0100, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: ACPI / property: Drop size_prop from acpi_dev_get_property_reference() > > The size_prop argument of the recently added function > acpi_dev_get_property_reference() is not used by the only current > caller of that function and is very unlikely to be used at any time > going forward. > > Namely, for a property whose value is a list of items each containing > a references to a device object possibly accompanied by some integers, > the number of items in the list can always be computed as the number > of elements of type ACPI_TYPE_LOCAL_REFERENCE in the property package. > Thus it should never be necessary to provide an additional "cells" > property with a value equal to the number of items in that list. > > For this reason, drop the size_prop argument from > acpi_dev_get_property_reference() and update its caller accordingly. > > Link: http://marc.info/?l=linux-kernel&m=141511255610556&w=2 > Suggested-by: Grant Likely > Signed-off-by: Rafael J. Wysocki Just pulled your latest bleeding-edge (including this patch) and it still works fine with both Minnowboards. Feel free to add my: Acked-by: Mika Westerberg Tested-by: Mika Westerberg -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/