Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754865AbaKENrO (ORCPT ); Wed, 5 Nov 2014 08:47:14 -0500 Received: from mail-wg0-f53.google.com ([74.125.82.53]:48881 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753888AbaKENrM (ORCPT ); Wed, 5 Nov 2014 08:47:12 -0500 Date: Wed, 5 Nov 2014 15:40:04 +0200 From: Aya Mahfouz To: Sudip Mukherjee Cc: Jarod Wilson , Mauro Carvalho Chehab , Greg Kroah-Hartman , Dan Carpenter , Tuomas Tynkkynen , Gulsah Kose , Matina Maria Trompouki , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: media: lirc: modify print calls Message-ID: <20141105134004.GA2493@localhost.localdomain> References: <20141104214307.GA6709@localhost.localdomain> <20141105112915.GA2680@sudip-PC> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141105112915.GA2680@sudip-PC> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 05, 2014 at 04:59:15PM +0530, Sudip Mukherjee wrote: > On Tue, Nov 04, 2014 at 11:43:07PM +0200, Aya Mahfouz wrote: > > This patches replaces one pr_debug call by dev_dbg and > > changes the device used by one of the dev_err calls. > > i think you should mention in the commit message why you are changing the device. > and also for revised patch its better if you add version number in the subject. > like this is v2. > > thanks > sudip > Thanks Sudip for your feedback. I use versions if I keep the same subject. Kind Regards, Aya Saif El-yazal Mahfouz > > > > Signed-off-by: Aya Mahfouz > > --- > > drivers/staging/media/lirc/lirc_zilog.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/staging/media/lirc/lirc_zilog.c b/drivers/staging/media/lirc/lirc_zilog.c > > index 52f8e91..dca806a 100644 > > --- a/drivers/staging/media/lirc/lirc_zilog.c > > +++ b/drivers/staging/media/lirc/lirc_zilog.c > > @@ -1447,7 +1447,7 @@ static int ir_probe(struct i2c_client *client, const struct i2c_device_id *id) > > int ret; > > bool tx_probe = false; > > > > - pr_debug("%s: %s on i2c-%d (%s), client addr=0x%02x\n", > > + dev_dbg(&client->dev, "%s: %s on i2c-%d (%s), client addr=0x%02x\n", > > __func__, id->name, adap->nr, adap->name, client->addr); > > > > /* > > @@ -1631,7 +1631,7 @@ out_put_xx: > > out_put_ir: > > put_ir_device(ir, true); > > out_no_ir: > > - dev_err(ir->l.dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n", > > + dev_err(&client->dev, "%s: probing IR %s on %s (i2c-%d) failed with %d\n", > > __func__, tx_probe ? "Tx" : "Rx", adap->name, adap->nr, > > ret); > > mutex_unlock(&ir_devices_lock); > > -- > > 1.9.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/