Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932134AbaKEPPp (ORCPT ); Wed, 5 Nov 2014 10:15:45 -0500 Received: from down.free-electrons.com ([37.187.137.238]:42505 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754771AbaKEPPm (ORCPT ); Wed, 5 Nov 2014 10:15:42 -0500 Date: Wed, 5 Nov 2014 16:15:38 +0100 From: Boris Brezillon To: Sakari Ailus Cc: Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Guennadi Liakhovetski Subject: Re: [PATCH 11/15] [media] Deprecate v4l2_mbus_pixelcode Message-ID: <20141105161538.7a1686d5@bbrezillon> In-Reply-To: <20141105150814.GT3136@valkosipuli.retiisi.org.uk> References: <1415094910-15899-1-git-send-email-boris.brezillon@free-electrons.com> <1415094910-15899-12-git-send-email-boris.brezillon@free-electrons.com> <20141105150814.GT3136@valkosipuli.retiisi.org.uk> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Nov 2014 17:08:15 +0200 Sakari Ailus wrote: > Hi Boris, > > On Tue, Nov 04, 2014 at 10:55:06AM +0100, Boris Brezillon wrote: > > The v4l2_mbus_pixelcode enum (or its values) should be replaced by the > > media_bus_format enum. > > Keep this enum in v4l2-mediabus.h and create a new header containing > > the v4l2_mbus_framefmt struct definition (which is not deprecated) so > > that we can add a #warning statement in v4l2-mediabus.h and hopefully > > encourage users to move to the new definitions. > > > > Replace inclusion of v4l2-mediabus.h with v4l2-mbus.h in all common headers > > and update the documentation Makefile to parse v4l2-mbus.h instead of > > v4l2-mediabus.h. > > > > Signed-off-by: Boris Brezillon > > --- > > Documentation/DocBook/media/Makefile | 2 +- > > include/media/v4l2-mediabus.h | 2 +- > > include/uapi/linux/Kbuild | 1 + > > include/uapi/linux/v4l2-mbus.h | 35 +++++++++++++++++++++++++++++++++++ > > include/uapi/linux/v4l2-mediabus.h | 26 ++++---------------------- > > I would keep the original file name, even if the compatibility definitions > are there. I don't see any harm in having them around as well. > That's the part I was not sure about. The goal of this patch (and the following ones) is to deprecate v4l2_mbus_pixelcode enum and its values by adding a #warning when v4l2-mediabus.h file is included, thus encouraging people to use new definitions. Do you see another solution to generate such warnings at compilation time ? -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/