Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755569AbaKERKN (ORCPT ); Wed, 5 Nov 2014 12:10:13 -0500 Received: from mail-vc0-f180.google.com ([209.85.220.180]:53149 "EHLO mail-vc0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751562AbaKERKL (ORCPT ); Wed, 5 Nov 2014 12:10:11 -0500 MIME-Version: 1.0 In-Reply-To: References: <20141031084220.GA29085@infradead.org> <20141103083447.GA8617@infradead.org> <20141105082721.GB19607@infradead.org> Date: Wed, 5 Nov 2014 09:10:10 -0800 X-Google-Sender-Auth: 3XpXZXjUDjUUMHe3VN3clnwr0kg Message-ID: Subject: Re: [RFC PATCH] fs: allow open(dir, O_TMPFILE|..., 0) with mode 0 From: Linus Torvalds To: Andy Lutomirski Cc: Eric Rannaud , Christoph Hellwig , "linux-kernel@vger.kernel.org" , Andrew Morton , Al Viro , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 5, 2014 at 7:32 AM, Andy Lutomirski wrote: > > I have no idea whether it's a security risk, but it's a serious "wtf?!?" risk. Yeah. And considering that the only apparently user of this read-only O_TMPFILE interface doesn't actually need it anyway because it carries around the whole "read-only to the client" information independently, I think the issue is moot. We don't need zero-sized read-only O_TMPFILE files. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/