Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752263AbaKEUdA (ORCPT ); Wed, 5 Nov 2014 15:33:00 -0500 Received: from mail-la0-f43.google.com ([209.85.215.43]:58855 "EHLO mail-la0-f43.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751316AbaKEUc4 (ORCPT ); Wed, 5 Nov 2014 15:32:56 -0500 MIME-Version: 1.0 In-Reply-To: References: <1613303dfaa91e6ff09cdd7860e0316765663ba6.1413923420.git.milosz@adfin.com> Date: Wed, 5 Nov 2014 15:32:54 -0500 Message-ID: Subject: Re: [PATCH 2/4] vfs: Define new syscalls preadv2,pwritev2 From: Milosz Tanski To: Jeff Moyer Cc: LKML , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , "linux-aio@kvack.org" , Mel Gorman , Volker Lendecke , Tejun Heo , "Theodore Ts'o" , Al Viro , Linux API , Michael Kerrisk Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I have fixed this in the version I'm going to be resubmitting today. - Milosz On Fri, Oct 24, 2014 at 11:46 AM, Jeff Moyer wrote: > Milosz Tanski writes: > >> diff --git a/include/uapi/asm-generic/unistd.h b/include/uapi/asm-generic/unistd.h >> index 22749c1..10f8883 100644 >> --- a/include/uapi/asm-generic/unistd.h >> +++ b/include/uapi/asm-generic/unistd.h >> @@ -213,6 +213,10 @@ __SC_COMP(__NR_pwrite64, sys_pwrite64, compat_sys_pwrite64) >> __SC_COMP(__NR_preadv, sys_preadv, compat_sys_preadv) >> #define __NR_pwritev 70 >> __SC_COMP(__NR_pwritev, sys_pwritev, compat_sys_pwritev) >> +#define __NR_preadv2 281 >> +__SC_COMP(__NR_preadv2, sys_preadv2) >> +#define __NR_pwritev2 282 >> +__SC_COMP(__NR_pwritev2, sys_pwritev2) > > This looks odd. First, __SC_COMP takes 3 arguments. Second, you are > going to need to implement compat wrappers for the new system calls. > > Cheers, > Jeff -- Milosz Tanski CTO 16 East 34th Street, 15th floor New York, NY 10016 p: 646-253-9055 e: milosz@adfin.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/