Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751232AbaKFBzk (ORCPT ); Wed, 5 Nov 2014 20:55:40 -0500 Received: from mail-pa0-f53.google.com ([209.85.220.53]:58412 "EHLO mail-pa0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931AbaKFBzh (ORCPT ); Wed, 5 Nov 2014 20:55:37 -0500 Message-ID: <1415238859.2840.22.camel@debian> Subject: Re: [PATCH 1/2 v2] x86, mce, severity: extend the the mce_severity From: Chen Yucong To: Tony Luck Cc: Borislav Petkov , Andi Kleen , aravind.gopalakrishnan@amd.com, Linux Edac Mailing List , Linux Kernel Mailing List In-Reply-To: References: <1415162873-1874-1-git-send-email-slaoub@gmail.com> <1415162873-1874-2-git-send-email-slaoub@gmail.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 06 Nov 2014 09:54:19 +0800 Mime-Version: 1.0 X-Mailer: Evolution 3.4.4-3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2014-11-05 at 10:27 -0800, Tony Luck wrote: > > +#define ONEXCP .excp = NO_EXCP > I'm sorry, this is a typing error. Thanks! > Shouldn't this be named "NOEXCP" and used in the initializations > for the deferred and UCNA table entries? > In fact, "NOEXCP" can be used in the initialization for the deferred and UCNA table entries. But it may affect the following snippet in do_machine_check(). /* * When machine check was for corrected/deferred handler don't * touch, unless we're panicing. */ if ((severity == MCE_KEEP_SEVERITY || severity == MCE_UCNA_SEVERITY) && !no_way_out) continue; If `no_way_out' equals 1, we may need to dump/decode corrected/deferred error information. So if we use "NOEXCP" to initialize the deferred and UCNA table entries, do_machine_check will skip checking deferred/UCNA entry when `no_way_out' is set to 1. thx! cyc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/