Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751225AbaKFGqj (ORCPT ); Thu, 6 Nov 2014 01:46:39 -0500 Received: from helcar.apana.org.au ([209.40.204.226]:41995 "EHLO helcar.apana.org.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750828AbaKFGqi (ORCPT ); Thu, 6 Nov 2014 01:46:38 -0500 Date: Thu, 6 Nov 2014 14:46:29 +0800 From: Herbert Xu To: Al Viro Cc: David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, bcrl@kvack.org, Masahide Nakamura , Hideaki YOSHIFUJI Subject: Re: ipv4: Use standard iovec primitive in raw_probe_proto_opt Message-ID: <20141106064629.GA29321@gondor.apana.org.au> References: <20141105035536.GO7996@ZenIV.linux.org.uk> <20141105.155054.2198151263164321219.davem@davemloft.net> <20141105210745.GT7996@ZenIV.linux.org.uk> <20141105.165719.835728206041332333.davem@davemloft.net> <20141106032533.GU7996@ZenIV.linux.org.uk> <20141106055023.GA28865@gondor.apana.org.au> <20141106064318.GW7996@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141106064318.GW7996@ZenIV.linux.org.uk> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 06, 2014 at 06:43:18AM +0000, Al Viro wrote: > On Thu, Nov 06, 2014 at 01:50:23PM +0800, Herbert Xu wrote: > > + /* We only need the first two bytes. */ > > + err = memcpy_fromiovecend((void *)&icmph, msg->msg_iov, 0, 2); > > + if (err) > > + return err; > > + > > + fl4->fl4_icmp_type = icmph.type; > > + fl4->fl4_icmp_code = icmph.code; > > That's more readable, but that exposes another problem in there - we read > the same piece of userland data twice, with no promise whatsoever that we'll > get the same value both times... Sure, but you have to be root anyway to write to raw sockets. Patches are welcome :) Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/