Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751971AbaKFIrV (ORCPT <rfc822;w@1wt.eu>);
	Thu, 6 Nov 2014 03:47:21 -0500
Received: from lgeamrelo02.lge.com ([156.147.1.126]:39472 "EHLO
	lgeamrelo02.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751269AbaKFIrS (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 6 Nov 2014 03:47:18 -0500
X-Original-SENDERIP: 10.177.222.213
X-Original-MAILFROM: iamjoonsoo.kim@lge.com
Date: Thu, 6 Nov 2014 17:49:07 +0900
From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
To: Weijie Yang <weijie.yang@samsung.com>
Cc: kamezawa.hiroyu@jp.fujitsu.com, "'Minchan Kim'" <minchan@kernel.org>,
        "'Andrew Morton'" <akpm@linux-foundation.org>, mgorman@suse.de,
        mina86@mina86.com, "'linux-kernel'" <linux-kernel@vger.kernel.org>,
        "'Linux-MM'" <linux-mm@kvack.org>,
        "'Weijie Yang'" <weijie.yang.kh@gmail.com>
Subject: Re: [PATCH 2/2] mm: page_isolation: fix zone_freepage accounting
Message-ID: <20141106084907.GA29209@js1304-P5Q-DELUXE>
References: <000101cff999$09225070$1b66f150$%yang@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <000101cff999$09225070$1b66f150$%yang@samsung.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Nov 06, 2014 at 04:09:08PM +0800, Weijie Yang wrote:
> If race between isolatation and allocation happens, we could need to move
> some freepages to MIGRATE_ISOLATE in __test_page_isolated_in_pageblock().
> The current code ignores the zone_freepage accounting after the move,
> which cause the zone NR_FREE_PAGES and NR_FREE_CMA_PAGES statistics incorrect.
> 
> This patch fixes this rare issue.

Hello,

After "fix freepage count problems in memory isolation" merged, this race
should not happen. I have to remove it in that patchset, but, I
forgot to remove it. Please remove this race handling code completely and
tag with stable. If we don't remove it, there is errornous situation
because get_freepage_migratetype() could return invalid migratetype
although the page is on the correct buddy list. So, we regard
no race situation as race one.

Thanks.

> 
> Signed-off-by: Weijie Yang <weijie.yang@samsung.com>
> ---
>  mm/page_isolation.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/page_isolation.c b/mm/page_isolation.c
> index 3ddc8b3..15b51de 100644
> --- a/mm/page_isolation.c
> +++ b/mm/page_isolation.c
> @@ -193,12 +193,15 @@ __test_page_isolated_in_pageblock(unsigned long pfn, unsigned long end_pfn,
>  			 * is MIGRATE_ISOLATE. Catch it and move the page into
>  			 * MIGRATE_ISOLATE list.
>  			 */
> -			if (get_freepage_migratetype(page) != MIGRATE_ISOLATE) {
> +			int migratetype = get_freepage_migratetype(page);
> +			if (migratetype != MIGRATE_ISOLATE) {
>  				struct page *end_page;
>  
>  				end_page = page + (1 << page_order(page)) - 1;
>  				move_freepages(page_zone(page), page, end_page,
>  						MIGRATE_ISOLATE);
> +				__mod_zone_freepage_state(zone,
> +					-(1 << page_order(page)), migratetype);
>  			}
>  			pfn += 1 << page_order(page);
>  		}
> -- 
> 1.7.0.4
> 
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@kvack.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/