Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751986AbaKFJEn (ORCPT ); Thu, 6 Nov 2014 04:04:43 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:56033 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751062AbaKFJEc (ORCPT ); Thu, 6 Nov 2014 04:04:32 -0500 Date: Thu, 6 Nov 2014 09:04:24 +0000 From: Lee Jones To: Dmitry Eremin-Solenikov Cc: Samuel Ortiz , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: tc6393xb: prepare/unprepare clocks Message-ID: <20141106090424.GB26543@x1> References: <1415263958-16644-1-git-send-email-dbaryshkov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1415263958-16644-1-git-send-email-dbaryshkov@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Nov 2014, Dmitry Eremin-Solenikov wrote: > Change clk_enable/disable() calls to clk_prepare_enable() and > clk_disable_unrepapre(). > > Signed-off-by: Dmitry Eremin-Solenikov > --- > drivers/mfd/tc6393xb.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) Applied, thanks. > diff --git a/drivers/mfd/tc6393xb.c b/drivers/mfd/tc6393xb.c > index 48579e5..abcb4eb 100644 > --- a/drivers/mfd/tc6393xb.c > +++ b/drivers/mfd/tc6393xb.c > @@ -665,7 +665,7 @@ static int tc6393xb_probe(struct platform_device *dev) > goto err_ioremap; > } > > - ret = clk_enable(tc6393xb->clk); > + ret = clk_prepare_enable(tc6393xb->clk); > if (ret) > goto err_clk_enable; > > @@ -728,7 +728,7 @@ err_gpio_add: > temp = gpiochip_remove(&tc6393xb->gpio); > tcpd->disable(dev); > err_enable: > - clk_disable(tc6393xb->clk); > + clk_disable_unprepare(tc6393xb->clk); > err_clk_enable: > iounmap(tc6393xb->scr); > err_ioremap: > @@ -764,7 +764,7 @@ static int tc6393xb_remove(struct platform_device *dev) > } > > ret = tcpd->disable(dev); > - clk_disable(tc6393xb->clk); > + clk_disable_unprepare(tc6393xb->clk); > iounmap(tc6393xb->scr); > release_resource(&tc6393xb->rscr); > clk_put(tc6393xb->clk); > @@ -792,7 +792,7 @@ static int tc6393xb_suspend(struct platform_device *dev, pm_message_t state) > ioread8(tc6393xb->scr + SCR_GPI_BCR(i)); > } > ret = tcpd->suspend(dev); > - clk_disable(tc6393xb->clk); > + clk_disable_unprepare(tc6393xb->clk); > > return ret; > } > @@ -804,7 +804,7 @@ static int tc6393xb_resume(struct platform_device *dev) > int ret; > int i; > > - clk_enable(tc6393xb->clk); > + clk_prepare_enable(tc6393xb->clk); > > ret = tcpd->resume(dev); > if (ret) -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/