Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752475AbaKFKc1 (ORCPT ); Thu, 6 Nov 2014 05:32:27 -0500 Received: from mail-la0-f50.google.com ([209.85.215.50]:59156 "EHLO mail-la0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbaKFKcW (ORCPT ); Thu, 6 Nov 2014 05:32:22 -0500 MIME-Version: 1.0 In-Reply-To: <20141106103033.GK1618@lahna.fi.intel.com> References: <1414755658-96293-1-git-send-email-mika.westerberg@linux.intel.com> <545843B1.3020101@nvidia.com> <2455157.3p7mHhT8im@vostro.rjw.lan> <20141106103033.GK1618@lahna.fi.intel.com> Date: Thu, 6 Nov 2014 11:32:19 +0100 X-Google-Sender-Auth: 1kk-8UOdwhqXsaO8XtzBTHmdKEE Message-ID: Subject: Re: [PATCH] leds: leds-gpio: Convert gpio_blink_set() to use GPIO descriptors From: Geert Uytterhoeven To: Mika Westerberg Cc: "Rafael J. Wysocki" , Alexandre Courbot , Linus Walleij , Bryan Wu , Richard Purdie , Ben Dooks , Kukjin Kim , Jason Cooper , Andrew Lunn , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , ACPI Devel Maling List , Linux-sh list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mika, On Thu, Nov 6, 2014 at 11:30 AM, Mika Westerberg wrote: >> "leds: leds-gpio: Add support for GPIO descriptors" broke leds-gpio on >> non-DT platforms for me: >> >> gpiod_direction_output: invalid GPIO >> leds-gpio: probe of leds-gpio failed with error -22 >> >> (desc is NULL in gpiod_direction_output()). >> >> DT shmobile reference/multi-platform are fine. >> >> I noticed the hard way, as I wanted to add some LEDs to a new platform, >> but couldn't get it work. It turned out it also had stopped working on >> r8a7740/armadillo-legacy, so I started bisecting... > > Which board file that is? > > There is a bug that gpio_to_desc() returns NULL instead if ERR_PTR() in > that patch but I wonder why gpio_is_valid() and devm_gpio_request_one() > do not complain about that prior. arch/arm/mach-shmobile/board-armadillo800eva.c Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/