Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751804AbaKFMbd (ORCPT ); Thu, 6 Nov 2014 07:31:33 -0500 Received: from mail-la0-f44.google.com ([209.85.215.44]:65535 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751423AbaKFMb0 (ORCPT ); Thu, 6 Nov 2014 07:31:26 -0500 Date: Thu, 6 Nov 2014 13:28:17 +0100 From: Johan Hovold To: Octavian Purdila Cc: Johan Hovold , Greg KH , Linus Walleij , Alexandre Courbot , wsa@the-dreams.de, sameo@linux.intel.com, Lee Jones , Arnd Bergmann , Daniel Baluta , Laurentiu Palcu , linux-usb@vger.kernel.org, lkml , linux-gpio@vger.kernel.org, linux-i2c@vger.kernel.org Subject: Re: [PATCH v10 1/3] mfd: add support for Diolan DLN-2 devices Message-ID: <20141106122817.GA26196@localhost> References: <1415207101-16461-1-git-send-email-octavian.purdila@intel.com> <1415207101-16461-2-git-send-email-octavian.purdila@intel.com> <20141105171103.GA21212@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.22 (2013-10-16) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 06, 2014 at 01:45:46PM +0200, Octavian Purdila wrote: > On Wed, Nov 5, 2014 at 7:11 PM, Johan Hovold wrote: > > On Wed, Nov 05, 2014 at 07:04:59PM +0200, Octavian Purdila wrote: > >> This patch implements the USB part of the Diolan USB-I2C/SPI/GPIO > >> Master Adapter DLN-2. Details about the device can be found here: > >> > >> https://www.diolan.com/i2c/i2c_interface.html. > >> > >> Information about the USB protocol can be found in the Programmer's > >> Reference Manual [1], see section 1.7. > >> > >> Because the hardware has a single transmit endpoint and a single > >> receive endpoint the communication between the various DLN2 drivers > >> and the hardware will be muxed/demuxed by this driver. > >> > >> Each DLN2 module will be identified by the handle field within the DLN2 > >> message header. If a DLN2 module issues multiple commands in parallel > >> they will be identified by the echo counter field in the message header. > >> > >> The DLN2 modules can use the dln2_transfer() function to issue a > >> command and wait for its response. They can also register a callback > >> that is going to be called when a specific event id is generated by > >> the device (e.g. GPIO interrupts). The device uses handle 0 for > >> sending events. > >> > >> [1] https://www.diolan.com/downloads/dln-api-manual.pdf > >> > >> Signed-off-by: Octavian Purdila > > > > Reviewed-by: Johan Hovold > > > > Just noticed checkpatch complains about two typos in the header file > > (since v9?). ;) > > > > Ah nice new checkpatch feature, I used checkpath before rebasing the > tree and missed those. I will fix the typos and submit v11 with your > review-by tags. Thanks a lot for your awesome reviews Johan ! You're welcome. Johan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/