Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id <S266842AbSLPK2V>; Mon, 16 Dec 2002 05:28:21 -0500
Received: (majordomo@vger.kernel.org) by vger.kernel.org
	id <S266840AbSLPK2U>; Mon, 16 Dec 2002 05:28:20 -0500
Received: from louise.pinerecords.com ([213.168.176.16]:48526 "EHLO
	louise.pinerecords.com") by vger.kernel.org with ESMTP
	id <S266842AbSLPK2T>; Mon, 16 Dec 2002 05:28:19 -0500
Date: Mon, 16 Dec 2002 11:35:58 +0100
From: Tomas Szepe <szepe@pinerecords.com>
To: Joe Thornber <joe@fib011235813.fsnet.co.uk>
Cc: Linus Torvalds <torvalds@transmeta.com>,
       Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: 6/19
Message-ID: <20021216103558.GA20223@louise.pinerecords.com>
References: <20021211121749.GA20782@reti> <Pine.LNX.4.44.0212151649180.2445-100000@home.transmeta.com> <20021216100457.GA7407@reti> <20021216100947.GG7407@reti>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20021216100947.GG7407@reti>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 625
Lines: 20

> +	/*
> +	 * chunk_size is a power of two
> +	 */
> +	if (!chunk_size || (chunk_size & (chunk_size - 1))) {
> +		ti->error = "dm-stripe: Invalid chunk size";
> +		return -EINVAL;
> +	}

Is 1 a valid chunksize then?  [It certainly is not a power of two. ;)]
If not, you need

	if (chink_size < 2 || (chunk_size & (chunk_size - 1))) { ... }

-- 
Tomas Szepe <szepe@pinerecords.com>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/