Date: Thu, 6 Nov 2014 16:50:56 -0500
From: Aristeu Rozanski <aris@redhat.com>
To: Dave Hansen <dave@sr71.net>
Cc: linux-kernel@vger.kernel.org, Changli Gao <xiaosuo@gmail.com>,
        David Rientjes <rientjes@google.com>, Eric Paris <eparis@redhat.com>,
        Hannes Frederic Sowa <hannes@stressinduktion.org>,
        Jesse Gross <jesse@nicira.com>, Jonathan Corbet <corbet@lwn.net>,
        Paul Gortmaker <paul.gortmaker@windriver.com>,
        Pravin Shelar <pshelar@nicira.com>,
        Alexander Viro <viro@zeniv.linux.org.uk>,
        Josh Triplett <josh@joshtriplett.org>
Subject: Re: [PATCH] lib/flex_array: make build optional
Message-ID: <20141106215056.GK26472@redhat.com>
References: <1415309241-12971-1-git-send-email-aris@redhat.com>
 <545BE927.9060208@sr71.net>
 <545BEBD6.4030803@sr71.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <545BEBD6.4030803@sr71.net>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Nov 06, 2014 at 01:44:54PM -0800, Dave Hansen wrote:
> On 11/06/2014 01:33 PM, Dave Hansen wrote:
> > On 11/06/2014 01:27 PM, Aristeu Rozanski wrote:
> >> +config FLEX_ARRAY
> >> +	bool "Flexible array"
> >> +	default n
> >> +	help
> >> +	  This option enables an implementation of flexible arrays which
> >> +	  allows creating arrays of fixed size elements with an arbritrary
> >> +	  size without requiring the single allocation of a contiguous area.
> >> +
> >> +	  See Documentation/flexible-arrays.txt
> > 
> > Is there any reason to expose this to the user via Kconfig?
> > 
> > No sane person would even turn it on if they don't need it.
> 
> IOW, I think you should just make it:
> 
> config FLEX_ARRAY
> 	def_bool n

Joe Pershes complained on a similar patch on making it default to 'n'.
Will rework the patches this way.

-- 
Aristeu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/