Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751416AbaKGEKN (ORCPT ); Thu, 6 Nov 2014 23:10:13 -0500 Received: from mho-03-ewr.mailhop.org ([204.13.248.66]:45801 "EHLO mho-01-ewr.mailhop.org" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751225AbaKGEKK (ORCPT ); Thu, 6 Nov 2014 23:10:10 -0500 X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 96.249.243.124 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/OTidzSTjsoVx8HakHH0JorC+3je74wws= X-DKIM: OpenDKIM Filter v2.0.1 titan 5411D613F2F Date: Thu, 6 Nov 2014 23:09:47 -0500 From: Jason Cooper To: Thomas Petazzoni Cc: Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , linux-arm-kernel@lists.infradead.org, Tawfik Bayouk , Nadav Haklai , Lior Amsalem , Ezequiel Garcia , devicetree@vger.kernel.org, Thomas Gleixner , linux-kernel@vger.kernel.org Subject: Re: [PATCH 03/17] irqchip: irq-armada-370-xp: use proper return value for ->set_affinity() Message-ID: <20141107040947.GG3698@titan.lakedaemon.net> References: <1414151970-6626-1-git-send-email-thomas.petazzoni@free-electrons.com> <1414151970-6626-4-git-send-email-thomas.petazzoni@free-electrons.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1414151970-6626-4-git-send-email-thomas.petazzoni@free-electrons.com> User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 24, 2014 at 01:59:16PM +0200, Thomas Petazzoni wrote: > The ->set_affinity() hook of 'struct irq_chip' is supposed to return > one of IRQ_SET_MASK_OK or IRQ_SET_MASK_OK_NOCOPY. However, the code > currently simply returns 0. This patch fixes that by using > IRQ_SET_MASK_OK, which tells the IRQ core that it is responsible for > updating irq_data.affinity. > > Note that this patch does not cause any change to the compiled code, > as IRQ_SET_MASK_OK has the value 0. This is therefore just a simple > cleanup. > > Signed-off-by: Thomas Petazzoni > Cc: Thomas Gleixner > Cc: Jason Cooper > Cc: linux-kernel@vger.kernel.org > --- > drivers/irqchip/irq-armada-370-xp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to irqchip/core with Gregory's Reviewed-by. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/