Message-ID: <1415354191.958.307.camel@sauron.fi.intel.com>
Subject: Re: [PATCH] UBI: Block: Add blk-mq support
From: Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind1@gmail.com
To: Richard Weinberger <richard@nod.at>
Cc: Christoph Hellwig <hch@infradead.org>, axboe@fb.com,
        ezequiel.garcia@free-electrons.com, dwmw2@infradead.org,
        computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Date: Fri, 07 Nov 2014 11:56:31 +0200
In-Reply-To: <545C96A1.40304@nod.at>
References: <1414933255-3795-1-git-send-email-richard@nod.at>
		 <20141103081821.GA5261@infradead.org> <54573B72.1060600@nod.at>
	 <1415353596.958.302.camel@sauron.fi.intel.com> <545C96A1.40304@nod.at>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Fri, 2014-11-07 at 10:53 +0100, Richard Weinberger wrote:
> Am 07.11.2014 um 10:46 schrieb Artem Bityutskiy:
> > On Mon, 2014-11-03 at 09:23 +0100, Richard Weinberger wrote:
> >> Am 03.11.2014 um 09:18 schrieb Christoph Hellwig:
> >>> On Sun, Nov 02, 2014 at 02:00:55PM +0100, Richard Weinberger wrote:
> >>>> +#define UBIBLOCK_SG_COUNT 64
> >>>
> >>>
> >>> Can you document why you choose this number? The default nr_request
> >>> for the old code would be 128.
> >>
> >> Is 64 a problem? Beside of the fact that I forgot to set blk_queue_max_segments().
> >> I used this number because 128 seemed a bit high and my goal was to
> >> keep the memory footprint small.
> >> This is also why I've set tag_set.queue_depth to 64.
> > 
> > The request was to document, so lets' document the choice.
> 
> Of course I'll document it. But so far I had no time to do a
> v2 of this patch.

Your reply just sounded like you are complaining to the request (starts
with "is this a problem?"). And it looked like you try to defend the 64
choice, while no one challenged it.

So my e-mail is to just kindly help you by pointing that the request was
to only add a piece of doc so far, in case you misinterpreted it.

Artem.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/