Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752885AbaKGOsK (ORCPT ); Fri, 7 Nov 2014 09:48:10 -0500 Received: from lb1-smtp-cloud2.xs4all.net ([194.109.24.21]:56748 "EHLO lb1-smtp-cloud2.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752664AbaKGOsI (ORCPT ); Fri, 7 Nov 2014 09:48:08 -0500 Message-ID: <545CDB8D.4080406@xs4all.nl> Date: Fri, 07 Nov 2014 15:47:41 +0100 From: Hans Verkuil User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Icedove/24.5.0 MIME-Version: 1.0 To: Boris Brezillon , Mauro Carvalho Chehab , Hans Verkuil , Laurent Pinchart , linux-media@vger.kernel.org, Sakari Ailus CC: linux-arm-kernel@lists.infradead.org, linux-api@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Guennadi Liakhovetski Subject: Re: [PATCH v3 10/10] [media] v4l: Forbid usage of V4L2_MBUS_FMT definitions inside the kernel References: <1415369269-5064-1-git-send-email-boris.brezillon@free-electrons.com> <1415369269-5064-11-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1415369269-5064-11-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Nitpicks: On 11/07/14 15:07, Boris Brezillon wrote: > Place v4l2_mbus_pixelcode in a #ifndef __KERNEL__ section so that kernel > users don't have access to these definitions. > > We have to keep this definition for user-space users even though they're > encouraged to move to the new media_bus_format enum. > > Signed-off-by: Boris Brezillon > --- > include/uapi/linux/v4l2-mediabus.h | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/include/uapi/linux/v4l2-mediabus.h b/include/uapi/linux/v4l2-mediabus.h > index 3d87db7..4f31d0e 100644 > --- a/include/uapi/linux/v4l2-mediabus.h > +++ b/include/uapi/linux/v4l2-mediabus.h > @@ -15,6 +15,14 @@ > #include > #include > > +#ifndef __KERNEL__ > + > +/* > + * enum v4l2_mbus_pixelcode and its defintions are now deprecated, and defintions -> definitions > + * MEDIA_BUS_FMT_ defintions (defined in media-bus-format.h) should be and again... > + * used instead. I would also add something like this: "New defines should only be added to media-bus-format.h. The v4l2_mbus_pixelcode enum is frozen." > + */ > + > #define V4L2_MBUS_FROM_MEDIA_BUS_FMT(name) \ > MEDIA_BUS_FMT_ ## name = V4L2_MBUS_FMT_ ## name > > @@ -102,6 +110,7 @@ enum v4l2_mbus_pixelcode { > > V4L2_MBUS_FROM_MEDIA_BUS_FMT(AHSV8888_1X32), > }; > +#endif /* __KERNEL__ */ > > /** > * struct v4l2_mbus_framefmt - frame format on the media bus > Can you move this struct forward to before the v4l2_mbus_pixelcode enum? That way the obsolete code is at the end of the header. People might miss this struct otherwise. Regards, Hans -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/