Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751443AbaKGPMT (ORCPT ); Fri, 7 Nov 2014 10:12:19 -0500 Received: from mail-wi0-f179.google.com ([209.85.212.179]:50944 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750957AbaKGPMR (ORCPT ); Fri, 7 Nov 2014 10:12:17 -0500 Date: Fri, 7 Nov 2014 15:12:09 +0000 From: Matt Fleming To: Sam Protsenko Cc: Matt Fleming , Leif Lindholm , hock.leong.kweh@intel.com, "linux-efi@vger.kernel.org" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] efi: Capsule update support Message-ID: <20141107151209.GL3592@console-pimps.org> References: <20141013095310.GZ14343@console-pimps.org> <20141016161507.GJ14343@console-pimps.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 04 Nov, at 03:56:22PM, Sam Protsenko wrote: > Matt, > > I've tested your patch with zero image size (no image passed, only headers) > and it crashes because there is no check for image size there. > This case (zero image size) seems to be legit according to specification > and also can be useful in real life. So I developed a little fix for your patch: [...] > I'm planning to use your API for our UpdateCapsule test module so > it would be really helpful if you can include this fix to your patch. Sure, I'll include that snippet and post fixed up code next week. Thanks Sam. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/