Date: Sat, 8 Nov 2014 12:36:25 +0100
From: Alban <albeu@free.fr>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Aban Bedel <albeu@free.fr>, linux-kernel@vger.kernel.org,
        linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH 1/2] MIPS: FW: Fix parsing u-boot environment
Message-ID: <20141108123625.5bf49656@tock>
In-Reply-To: <545CBE5E.3050906@cogentembedded.com>
References: <1415359381-27257-1-git-send-email-albeu@free.fr>
	<545CBE5E.3050906@cogentembedded.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Fri, 07 Nov 2014 15:43:10 +0300
Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> wrote:

> Hello.
> 
> On 11/7/2014 2:23 PM, Alban Bedel wrote:
> 
> > When reading u-boot's key=value pairs it should skip the '=' and not
> > use the next argument.
> 
> > Signed-off-by: Alban Bedel <albeu@free.fr>
> > ---
> >   arch/mips/fw/lib/cmdline.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> > diff --git a/arch/mips/fw/lib/cmdline.c b/arch/mips/fw/lib/cmdline.c
> > index ffd0345..cc5d168 100644
> > --- a/arch/mips/fw/lib/cmdline.c
> > +++ b/arch/mips/fw/lib/cmdline.c
> > @@ -68,7 +68,7 @@ char *fw_getenv(char *envname)
> >   					result = fw_envp(index +
> > 1); break;
> >   				} else if (fw_envp(index)[i] ==
> > '=') {
> > -					result = (fw_envp(index +
> > 1) + i);
> > +					result = (fw_envp(index) +
> > i + 1);
> 
>     Perhaps it's time to drop the useless outer parens?

I agree, I'm sending a new serie.

Alban
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/