Date: Sun, 9 Nov 2014 13:47:51 -0800
From: =?utf-8?B?U8O2cmVu?= Brinkmann <soren.brinkmann@xilinx.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
CC: <linux-kernel@vger.kernel.org>, <michals@xilinx.com>, <sorenb@xilinx.com>,
        <steven.wang@digilentinc.com>
Subject: Re: [PATCH 2/2] arm: dts: zynq: Add Digilent ZYBO board
References: <1415504283-31321-1-git-send-email-crosthwaite.peter@gmail.com>
 <1415504283-31321-2-git-send-email-crosthwaite.peter@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
In-Reply-To: <1415504283-31321-2-git-send-email-crosthwaite.peter@gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-ID: <548fd9c6edf94ca2b20299895f78b139@BN1AFFO11FD036.protection.gbl>
Sender: linux-kernel-owner@vger.kernel.org

Hi Peter,

On Sun, 2014-11-09 at 01:38PM +1000, Peter Crosthwaite wrote:
> Add a DTS describing the Digilent ZYBO board. Similar to ZED but with

"Digilent ZYBO" here...

[...]
> +/ {
> +	model = "Zynq ZYBO Development Board";
> +	compatible = "xlnx,zynq-zybo", "xlnx,zynq-7000";

... "xlnx,zynq-zybo" here. Seems inconsistent. IMHO, there should rather be
a digilent vendor prefix.

Everything else looks pretty straight forward and good.

	Soren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/