Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751735AbaKJAPl (ORCPT ); Sun, 9 Nov 2014 19:15:41 -0500 Received: from forward20.mail.yandex.net ([95.108.253.145]:41505 "EHLO forward20.mail.yandex.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751274AbaKJAPk (ORCPT ); Sun, 9 Nov 2014 19:15:40 -0500 X-Greylist: delayed 330 seconds by postgrey-1.27 at vger.kernel.org; Sun, 09 Nov 2014 19:15:39 EST From: =?koi8-r?B?5dfHxc7JyiDwz8zRy8/X?= Envelope-From: drustafa@yandex.ru To: NeilBrown Cc: "linux-kernel@vger.kernel.org" , GTA04 owners In-Reply-To: <20141108103249.4f86786c@notabene.brown> References: <20141108103249.4f86786c@notabene.brown> Subject: Re: [PATCH] w1: support auto-load of w1_bq27000 module. MIME-Version: 1.0 Message-Id: <18301415578289@web5g.yandex.ru> X-Mailer: Yamail [ http://yandex.ru ] 5.0 Date: Mon, 10 Nov 2014 03:11:29 +0300 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=koi8-r Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi 08.11.2014, 02:33, "NeilBrown" : > 1/ change request_module call to zero-pad single digit > ???family numbers. ?This appears to be the intention of > ???the code, but not what it actually does. > > ???This means that the alias created for W1_FAMILY_SMEM_01 > ???might actually be useful. > > 2/ Define a family name for the BQ27000 battery charge monitor. > ???Unfortunately this is the same number as W1_FAMILY_SMEM_01 > ???so if both a compiled on a system, one module might need to > ???be blacklisted. > > 3/ Add a MODULE_ALIAS for the bq27000. > > Signed-off-by: NeilBrown Looks good to me. Acked-by: Evgeniy Polyakov Which tree should this patch use to get into the kernel? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/