Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752073AbaKJHqP (ORCPT ); Mon, 10 Nov 2014 02:46:15 -0500 Received: from ns.mm-sol.com ([37.157.136.199]:60067 "EHLO extserv.mm-sol.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751803AbaKJHqN (ORCPT ); Mon, 10 Nov 2014 02:46:13 -0500 Message-ID: <1415605592.22935.3.camel@mm-sol.com> Subject: Re: [PATCH] mfd: qcom-spmi-pmic: Add support for more chips versions From: "Ivan T. Ivanov" To: Gilad Avidov Cc: Bjorn Andersson , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Samuel Ortiz , Lee Jones , Stanimir Varbanov , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , linux-arm-msm Date: Mon, 10 Nov 2014 09:46:32 +0200 In-Reply-To: <545D5EEA.8020800@codeaurora.org> References: <1415108003-16387-1-git-send-email-iivanov@mm-sol.com> <1415212271.14949.1.camel@mm-sol.com> <1415260480.13103.3.camel@mm-sol.com> <545D5EEA.8020800@codeaurora.org> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.13.6-fta3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Gilad, On Fri, 2014-11-07 at 17:08 -0700, Gilad Avidov wrote: > On 11/6/2014 12:54 AM, Ivan T. Ivanov wrote: > > On Wed, 2014-11-05 at 17:36 -0800, Bjorn Andersson wrote: > > > On Wed, Nov 5, 2014 at 10:31 AM, Ivan T. Ivanov wrote: > > > > On Wed, 2014-11-05 at 10:11 -0800, Bjorn Andersson wrote: > > > > > On Tue, Nov 4, 2014 at 5:33 AM, Ivan T. Ivanov > > > > > wrote: > > > > > [..] > > > > > > @@ -28,11 +144,27 @@ static int pmic_spmi_probe(struct spmi_device > > > > > > *sdev) > > > > > > { > > > > > > struct device_node *root = sdev->dev.of_node; > > > > > > struct regmap *regmap; > > > > > > + struct property *prop; > > > > > > + int major, minor, ret; > > > > > > + char *name, compatible[32]; > > > > > > > > > > > > regmap = devm_regmap_init_spmi_ext(sdev, > > > > > > &spmi_regmap_config); > Hi Ivan, I have a general question about this driver/layer. > Since the driver is using regmap, why does it need to be > qcom-*spmi*-pmic ? could we drop the spmi part? > regmap's point is abstraction of the bus technology, and indeed some > PMICs use i2c. This is driver for SPMI device, so no. The child device/drivers are different question, but I don't want to start that discussion again. Regards, Ivan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/