Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752451AbaKJJ0c (ORCPT ); Mon, 10 Nov 2014 04:26:32 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:42718 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752245AbaKJJ0b (ORCPT ); Mon, 10 Nov 2014 04:26:31 -0500 Message-ID: <546084A8.9070601@st.com> Date: Mon, 10 Nov 2014 10:26:00 +0100 From: Maxime Coquelin User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Peter Griffin , , , , Cc: , Subject: Re: [PATCH 10/13] ARM: STi: DT: STih410: Add dt nodes for the ehci / ohci usb controllers. References: <1415361475-6218-1-git-send-email-peter.griffin@linaro.org> <1415361475-6218-11-git-send-email-peter.griffin@linaro.org> In-Reply-To: <1415361475-6218-11-git-send-email-peter.griffin@linaro.org> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.251.17.209] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.12.52,1.0.28,0.0.0000 definitions=2014-11-10_01:2014-11-07,2014-11-09,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, On 11/07/2014 12:57 PM, Peter Griffin wrote: > The stih410 has some additional usb controllers. This patch adds the > dt nodes which will enabled them to function correctly. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407.dtsi | 60 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407.dtsi b/arch/arm/boot/dts/stih407.dtsi > index 967ec39..5e01db2 100644 > --- a/arch/arm/boot/dts/stih407.dtsi > +++ b/arch/arm/boot/dts/stih407.dtsi Shouldn't you create a new stih410.dtsi file, to clearly highlight these USB2 controller are not present on STiH407? If you create this file, you could also include the stih410-clocks.dtsi file in it. > @@ -321,5 +321,65 @@ > reset-names = "global", > "port"; > }; > + > + ohci0: usb@9a03c00 { > + compatible = "st,st-ohci-300x"; > + status = "disabled"; > + reg = <0x9a03c00 0x100>; > + interrupts = ; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>, > + <&softreset STIH407_USB2_PORT0_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy0>; > + phy-names = "usb"; > + }; > + > + ehci0: usb@9a03e00 { > + compatible = "st,st-ehci-300x"; > + status = "disabled"; > + reg = <0x9a03e00 0x100>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb0>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>, > + <&softreset STIH407_USB2_PORT0_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy0>; > + phy-names = "usb"; > + }; > + > + ohci1: usb@9a83c00 { > + compatible = "st,st-ohci-300x"; > + status = "disabled"; > + reg = <0x9a83c00 0x100>; > + interrupts = ; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>, > + <&softreset STIH407_USB2_PORT1_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy1>; > + phy-names = "usb"; > + }; > + > + ehci1: usb@9a83e00 { > + compatible = "st,st-ehci-300x"; > + status = "disabled"; > + reg = <0x9a83e00 0x100>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb1>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>, > + <&softreset STIH407_USB2_PORT1_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy1>; > + phy-names = "usb"; > + }; > }; > }; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/