Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752322AbaKJJxT (ORCPT ); Mon, 10 Nov 2014 04:53:19 -0500 Received: from mailapp01.imgtec.com ([195.59.15.196]:57193 "EHLO mailapp01.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751741AbaKJJxR (ORCPT ); Mon, 10 Nov 2014 04:53:17 -0500 Message-ID: <54608B03.9050805@imgtec.com> Date: Mon, 10 Nov 2014 09:53:07 +0000 From: Zubair Lutfullah Kakakhel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Andy Yan , , , , CC: Greg Kroah-Hartman , Grant Likely , Rob Herring , Philipp Zabel , Shawn Guo , Josh Boyer , Sean Paul , Inki Dae , Dave Airlie , Arnd Bergmann , Lucas Stach , , , , , , , , Subject: Re: [PATCH V5 7/7] dt-bindings: add document for dw-hdmi References: <1415424410-7364-1-git-send-email-andy.yan@rock-chips.com> <1415424767-7761-1-git-send-email-andy.yan@rock-chips.com> <546082A9.5050203@imgtec.com> <546088F6.4090505@rock-chips.com> In-Reply-To: <546088F6.4090505@rock-chips.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Originating-IP: [192.168.154.89] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/11/14 09:44, Andy Yan wrote: > Hi ZubairLK > On 2014年11月10日 17:17, Zubair Lutfullah Kakakhel wrote: >> Nice work. >> >> This patch should move the binding from >> >> Documentation/devicetree/bindings/staging/imx-drm/hdmi.txt >> to the location instead of making a new file and leaving the old >> one in place. >> >> And use git format-patch -M to highlight any changes. >> >> Regards >> ZubairLK > I add these bindings for dw-hdmi core, because > properities like reg, interrupts, ddc-i2c-bus, reg-io-width are used > by dw-hdmi core, but properities like compatible, gpr,clk, are platform > specific , they are handled by the platform code like dw_hdmi-imx.c > and described in platform specific dt binds like /imx-drm/hdmi.txt I understand. Are there any changes to imx-drm/hdmi.txt? Some properties for imx-drm/hdmi.txt would become optional/inherited from the parent hdmi drm binding? The changes should be highlighted in the commit message. Or we'll be confused which is which.. ZubairLK >> On 08/11/14 05:32, Andy Yan wrote: >>> Signed-off-by: Andy Yan >>> --- >>> .../devicetree/bindings/drm/bridge/dw-hdmi.txt | 38 ++++++++++++++++++++++ >>> 1 file changed, 38 insertions(+) >>> create mode 100644 Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>> >>> diff --git a/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>> new file mode 100644 >>> index 0000000..aa7ed17 >>> --- /dev/null >>> +++ b/Documentation/devicetree/bindings/drm/bridge/dw-hdmi.txt >>> @@ -0,0 +1,38 @@ >>> +DesignWare HDMI bridge bindings >>> + >>> +Required properities: >>> +- compatibel: platform specific such as "fsl,imx6q-hdmi","fsl,imx6dl-hdmi" spellcheck. compatible >>> + "rockchip,rk3288-dw-hdmi" >>> +- reg: physical base address of the controller and length >>> +- ddc-i2c-bus: the ddc i2c bus >>> +- interrupts: The interrupt number to the cpu >>> + >>> +Optional properties >>> +- reg-io-width: the width of the reg:1,4, default set to 1 if not present >>> + >>> +Example: >>> + hdmi: hdmi@0120000 { >>> + compatible = "fsl,imx6q-hdmi"; >>> + reg = <0x00120000 0x9000>; >>> + interrupts = <0 115 0x04>; >>> + gpr = <&gpr>; >>> + clocks = <&clks 123>, <&clks 124>; >>> + clock-names = "iahb", "isfr"; >>> + ddc-i2c-bus = <&i2c2>; >>> + >>> + port@0 { >>> + reg = <0>; >>> + >>> + hdmi_mux_0: endpoint { >>> + remote-endpoint = <&ipu1_di0_hdmi>; >>> + }; >>> + }; >>> + >>> + port@1 { >>> + reg = <1>; >>> + >>> + hdmi_mux_1: endpoint { >>> + remote-endpoint = <&ipu1_di1_hdmi>; >>> + }; >>> + }; >>> + }; >>> >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/