Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752681AbaKJKG1 (ORCPT ); Mon, 10 Nov 2014 05:06:27 -0500 Received: from mail-ig0-f181.google.com ([209.85.213.181]:33056 "EHLO mail-ig0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752597AbaKJKGZ (ORCPT ); Mon, 10 Nov 2014 05:06:25 -0500 Date: Mon, 10 Nov 2014 10:06:19 +0000 From: Lee Jones To: Peter Griffin Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, srinivas.kandagatla@gmail.com, maxime.coquelin@st.com, patrice.chotard@st.com, devicetree@vger.kernel.org Subject: Re: [PATCH 10/13] ARM: STi: DT: STih410: Add dt nodes for the ehci / ohci usb controllers. Message-ID: <20141110100619.GM21424@x1> References: <1415361475-6218-1-git-send-email-peter.griffin@linaro.org> <1415361475-6218-11-git-send-email-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1415361475-6218-11-git-send-email-peter.griffin@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 07 Nov 2014, Peter Griffin wrote: > The stih410 has some additional usb controllers. This patch adds the > dt nodes which will enabled them to function correctly. > > Signed-off-by: Peter Griffin > --- > arch/arm/boot/dts/stih407.dtsi | 60 ++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/arch/arm/boot/dts/stih407.dtsi b/arch/arm/boot/dts/stih407.dtsi > index 967ec39..5e01db2 100644 > --- a/arch/arm/boot/dts/stih407.dtsi > +++ b/arch/arm/boot/dts/stih407.dtsi > @@ -321,5 +321,65 @@ > reset-names = "global", > "port"; > }; > + > + ohci0: usb@9a03c00 { > + compatible = "st,st-ohci-300x"; > + status = "disabled"; Being picky, I like to see the node status at the bottom in clear view, but apart from that patch looks good: Acked-by: Lee Jones > + reg = <0x9a03c00 0x100>; > + interrupts = ; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>, > + <&softreset STIH407_USB2_PORT0_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy0>; > + phy-names = "usb"; > + }; > + > + ehci0: usb@9a03e00 { > + compatible = "st,st-ehci-300x"; > + status = "disabled"; > + reg = <0x9a03e00 0x100>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb0>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT0_POWERDOWN>, > + <&softreset STIH407_USB2_PORT0_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy0>; > + phy-names = "usb"; > + }; > + > + ohci1: usb@9a83c00 { > + compatible = "st,st-ohci-300x"; > + status = "disabled"; > + reg = <0x9a83c00 0x100>; > + interrupts = ; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>, > + <&softreset STIH407_USB2_PORT1_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy1>; > + phy-names = "usb"; > + }; > + > + ehci1: usb@9a83e00 { > + compatible = "st,st-ehci-300x"; > + status = "disabled"; > + reg = <0x9a83e00 0x100>; > + interrupts = ; > + pinctrl-names = "default"; > + pinctrl-0 = <&pinctrl_usb1>; > + clocks = <&clk_s_c0_flexgen CLK_TX_ICN_DISP_0>; > + resets = <&powerdown STIH407_USB2_PORT1_POWERDOWN>, > + <&softreset STIH407_USB2_PORT1_SOFTRESET>; > + reset-names = "power", "softreset"; > + > + phys = <&usb2_picophy1>; > + phy-names = "usb"; > + }; > }; > }; -- Lee Jones Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/