Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752722AbaKJUz0 (ORCPT ); Mon, 10 Nov 2014 15:55:26 -0500 Received: from mail-wg0-f47.google.com ([74.125.82.47]:59300 "EHLO mail-wg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751427AbaKJUzY (ORCPT ); Mon, 10 Nov 2014 15:55:24 -0500 Date: Mon, 10 Nov 2014 21:55:18 +0100 From: Robert Richter To: Jiang Liu Cc: Tejun Heo , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org, Sunil Goutham , Robert Richter Subject: Re: [PATCH] AHCI: Add generic MSI-X interrupt support to SATA PCI driver Message-ID: <20141110205518.GY20170@rric.localhost> References: <1415597417-10547-1-git-send-email-rric@kernel.org> <5460D100.90403@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5460D100.90403@linux.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.11.14 22:51:44, Jiang Liu wrote: > On 2014/11/10 13:30, Robert Richter wrote: > > From: Sunil Goutham > > + /* only enable the first entry (entry.entry = 0) */ > > + rc = pci_enable_msix_exact(pdev, &entry, 1); > > + if (rc < 0) > > + return rc; > > + > > + pdev->irq = entry.vector; > You can't overwrite pci_dev->irq for MSI-X, it's no way to > recover original irq for INTx after unbinding ahci driver. Instead, > you may access msi_desc->irq when requesting irq. Right, I have a version now that determines the irq vector from pdev->msi_list. -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/