Date: Mon, 10 Nov 2014 14:42:31 -0800
From: =?utf-8?B?U8O2cmVu?= Brinkmann <soren.brinkmann@xilinx.com>
To: Peter Crosthwaite <crosthwaitepeter@gmail.com>
CC: <linux-kernel@vger.kernel.org>, <michals@xilinx.com>, <sorenb@xilinx.com>,
        Steve Wang <steven.wang@digilentinc.com>
Subject: Re: [PATCH 2/2] arm: dts: zynq: Add Digilent ZYBO board
References: <1415504283-31321-1-git-send-email-crosthwaite.peter@gmail.com>
 <1415504283-31321-2-git-send-email-crosthwaite.peter@gmail.com>
 <548fd9c6edf94ca2b20299895f78b139@BN1AFFO11FD036.protection.gbl>
 <CAPokK=ovsR--ARj-2rNV6udbPEPqy4bChqC5FJw-u6O=cnHZQA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAPokK=ovsR--ARj-2rNV6udbPEPqy4bChqC5FJw-u6O=cnHZQA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Message-ID: <a7677222807f4dd3a7d74df647e48598@BL2FFO11FD053.protection.gbl>
Sender: linux-kernel-owner@vger.kernel.org

On Tue, 2014-11-11 at 08:39AM +1000, Peter Crosthwaite wrote:
> On Mon, Nov 10, 2014 at 7:47 AM, Sören Brinkmann
> <soren.brinkmann@xilinx.com> wrote:
> > Hi Peter,
> >
> > On Sun, 2014-11-09 at 01:38PM +1000, Peter Crosthwaite wrote:
> >> Add a DTS describing the Digilent ZYBO board. Similar to ZED but with
> >
> > "Digilent ZYBO" here...
> >
> > [...]
> >> +/ {
> >> +     model = "Zynq ZYBO Development Board";
> >> +     compatible = "xlnx,zynq-zybo", "xlnx,zynq-7000";
> >
> > ... "xlnx,zynq-zybo" here. Seems inconsistent. IMHO, there should rather be
> > a digilent vendor prefix.
> >
> 
> Was going for consistency with ZED which also makes this mistake:
> 
>     model = "Zynq Zed Development Board";
>     compatible = "xlnx,zynq-zed", "xlnx,zynq-7000";
> 
> We have to choose between consistency and correctness. If we do fix it
> though, what is Diglent's four-letter vendor prefix?

Since Digilent is the board vendor, I'm for using the appropriate
prefix. Vendor prefixes are found in
Documentation/devicetree/bindings/vendor-prefixes.txt.

	Soren
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/