Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751544AbaKJW4h (ORCPT ); Mon, 10 Nov 2014 17:56:37 -0500 Received: from mail-qa0-f45.google.com ([209.85.216.45]:45708 "EHLO mail-qa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751152AbaKJW4g convert rfc822-to-8bit (ORCPT ); Mon, 10 Nov 2014 17:56:36 -0500 MIME-Version: 1.0 In-Reply-To: References: <1415504283-31321-1-git-send-email-crosthwaite.peter@gmail.com> <1415504283-31321-2-git-send-email-crosthwaite.peter@gmail.com> <548fd9c6edf94ca2b20299895f78b139@BN1AFFO11FD036.protection.gbl> Date: Tue, 11 Nov 2014 08:56:33 +1000 Message-ID: Subject: Re: [PATCH 2/2] arm: dts: zynq: Add Digilent ZYBO board From: Peter Crosthwaite To: =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , Steve Wang Cc: linux-kernel@vger.kernel.org, michals@xilinx.com, sorenb@xilinx.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 11, 2014 at 8:42 AM, Sören Brinkmann wrote: > On Tue, 2014-11-11 at 08:39AM +1000, Peter Crosthwaite wrote: >> On Mon, Nov 10, 2014 at 7:47 AM, Sören Brinkmann >> wrote: >> > Hi Peter, >> > >> > On Sun, 2014-11-09 at 01:38PM +1000, Peter Crosthwaite wrote: >> >> Add a DTS describing the Digilent ZYBO board. Similar to ZED but with >> > >> > "Digilent ZYBO" here... >> > >> > [...] >> >> +/ { >> >> + model = "Zynq ZYBO Development Board"; >> >> + compatible = "xlnx,zynq-zybo", "xlnx,zynq-7000"; >> > >> > ... "xlnx,zynq-zybo" here. Seems inconsistent. IMHO, there should rather be >> > a digilent vendor prefix. >> > >> >> Was going for consistency with ZED which also makes this mistake: >> >> model = "Zynq Zed Development Board"; >> compatible = "xlnx,zynq-zed", "xlnx,zynq-7000"; >> >> We have to choose between consistency and correctness. If we do fix it >> though, what is Diglent's four-letter vendor prefix? > > Since Digilent is the board vendor, I'm for using the appropriate > prefix. Vendor prefixes are found in > Documentation/devicetree/bindings/vendor-prefixes.txt. > It's not there, Steven, does Digilent have a preferred dts vendor prefix? Regards, Peter > Soren -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/