Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751422AbaKKAym (ORCPT ); Mon, 10 Nov 2014 19:54:42 -0500 Received: from eusmtp01.atmel.com ([212.144.249.242]:39410 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751193AbaKKAyl convert rfc822-to-8bit (ORCPT ); Mon, 10 Nov 2014 19:54:41 -0500 From: "Yang, Wenyou" To: Sergei Shtylyov , "wsa@the-dreams.de" , "Desroches, Ludovic" CC: "khilman@kernel.org" , "Ferre, Nicolas" , "linux-kernel@vger.kernel.org" , "linux-i2c@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" Subject: RE: [PATCH v4] i2c/at91: adopt pinctrl support Thread-Topic: [PATCH v4] i2c/at91: adopt pinctrl support Thread-Index: AQHP/InvhgNJHH4o3UKhfhmASErLeZxZL4QAgAFo5TA= Date: Tue, 11 Nov 2014 00:53:58 +0000 Message-ID: References: <1415584552-11390-1-git-send-email-wenyou.yang@atmel.com> <54609DD8.8030903@cogentembedded.com> In-Reply-To: <54609DD8.8030903@cogentembedded.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.168.5.13] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, > -----Original Message----- > From: Sergei Shtylyov [mailto:sergei.shtylyov@cogentembedded.com] > Sent: Monday, November 10, 2014 7:13 PM > To: Yang, Wenyou; wsa@the-dreams.de; Desroches, Ludovic > Cc: khilman@kernel.org; Ferre, Nicolas; linux-kernel@vger.kernel.org; linux- > i2c@vger.kernel.org; linux-arm-kernel@lists.infradead.org > Subject: Re: [PATCH v4] i2c/at91: adopt pinctrl support > > Hello. > > On 11/10/2014 4:55 AM, Wenyou Yang wrote: > > > Amend the at91 i2c pin controller > > You're amending the hardware itself, really? :-) > > > to optionally take a pin controlhandle > > I don't see the code that does this. > > > and set the state of the pins to: > > - "default" on boot and resume. > > I don't see where you are changing anything for the probe() method. > Perhaps you meant the driver core code which selects the dafault profile > automatically? Yes, the driver core code default do, so remove the redundant code from _probe function. > > > - "sleep" on suspend(). > > > This should make it possible to optimize energy usage for the pins > > both for the suspend/resume cycle > > > Signed-off-by: Wenyou Yang > > --- > > Hi Wolfram, > > > > Thanks a lot. > > > > The change of this version is to remove > > pinctrl_pm_select_default_state(&pdev->dev) from the _probe function. > > Aha, you've specifically removed this... > > WBR, Sergei Best Regards, Wenyou Yang -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/