Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751781AbaKKCUH (ORCPT ); Mon, 10 Nov 2014 21:20:07 -0500 Received: from mail-pd0-f170.google.com ([209.85.192.170]:51285 "EHLO mail-pd0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbaKKCUF (ORCPT ); Mon, 10 Nov 2014 21:20:05 -0500 Message-ID: <54617251.10306@gmail.com> Date: Mon, 10 Nov 2014 18:20:01 -0800 From: Frank Rowand Reply-To: frowand.list@gmail.com User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: frowand.list@gmail.com CC: Stephen Boyd , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-serial@vger.kernel.org Subject: Re: [PATCH] tty: serial: msm_serial: Use DT aliases References: <1414024381-12204-1-git-send-email-sboyd@codeaurora.org> <545C4E1F.4060401@gmail.com> In-Reply-To: <545C4E1F.4060401@gmail.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Frank Rowand v2, changes from v1: - The patch this documents was updated to make the serialN alias optional instead of required. Update devicetree binding for msm_serial to reflect msm_serial_probe() getting line id from the serial alias. Signed-off-by: Frank Rowand --- Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt | 15 +++++++++-- 1 file changed, 13 insertions(+), 2 deletions(-) Index: linux/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt =================================================================== --- linux.orig/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt +++ linux/Documentation/devicetree/bindings/serial/qcom,msm-uartdm.txt @@ -27,11 +27,21 @@ Optional properties: - dmas: Should contain dma specifiers for transmit and receive channels - dma-names: Should contain "tx" for transmit and "rx" for receive channels +Note: Each UART port should have an alias correctly numbered in the +"aliases" node, according to serialN format, where N is the port number +(non-negative decimal integer). If the aliases are not present then +the port numbers will be 0..(number of UARTS - 1), assigned in the driver +probe order. + Examples: A uartdm v1.4 device with dma capabilities. -serial@f991e000 { +aliases { + serial0 = &serial0; +}; + +serial0: serial@f991e000 { compatible = "qcom,msm-uartdm-v1.4", "qcom,msm-uartdm"; reg = <0xf991e000 0x1000>; interrupts = <0 108 0x0>; @@ -43,7 +53,11 @@ serial@f991e000 { A uartdm v1.3 device without dma capabilities and part of a GSBI complex. -serial@19c40000 { +aliases { + serial0 = &serial0; +}; + +serial0: serial@19c40000 { compatible = "qcom,msm-uartdm-v1.3", "qcom,msm-uartdm"; reg = <0x19c40000 0x1000>, <0x19c00000 0x1000>; -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/