From: Dexuan Cui <decui@microsoft.com>
To: Vitaly Kuznetsov <vkuznets@redhat.com>, KY Srinivasan <kys@microsoft.com>,
        Haiyang Zhang <haiyangz@microsoft.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: "devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2 1/2] Tools: hv: vssdaemon: report freeze errors
Thread-Topic: [PATCH v2 1/2] Tools: hv: vssdaemon: report freeze errors
Thread-Index: AQHP/QSmTDkvs8aF8EqpOHM4Gza9PpxavR/Q
Date: Tue, 11 Nov 2014 03:07:02 +0000
Message-ID: <F792CF86EFE20D4AB8064279AFBA51C6105DFD0B@HKNPRD3002MB017.064d.mgd.msft.net>
References: <1415637422-27880-1-git-send-email-vkuznets@redhat.com>
 <1415637422-27880-2-git-send-email-vkuznets@redhat.com>
In-Reply-To: <1415637422-27880-2-git-send-email-vkuznets@redhat.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org

> -----Original Message-----
> From: Vitaly Kuznetsov
> Sent: Tuesday, November 11, 2014 0:37 AM
> To: KY Srinivasan; Haiyang Zhang; Greg Kroah-Hartman
> Cc: devel@linuxdriverproject.org; linux-kernel@vger.kernel.org; Dexuan Cui
> Subject: [PATCH v2 1/2] Tools: hv: vssdaemon: report freeze errors
> 
> When ioctl(fd, FIFREEZE, 0) results in an error we cannot report it
> to syslog instantly since that can cause write to a frozen disk.
> However, the name of the filesystem which caused the error and errno
> are valuable and we would like to get a nice human-readable message
> in the log. Save errno before calling vss_operate(VSS_OP_THAW) and
> report the error right after.
> 
> Unfortunately, FITHAW errors cannot be reported the same way as we
> need to finish thawing all filesystems before calling syslog().
> 
> We should also avoid calling endmntent() for the second time in
> case we encountered an error during freezing of '/' as it usually
> results in SEGSEGV.
> 
> Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
> ---
>  tools/hv/hv_vss_daemon.c | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)

Hi Vitaly,
Thanks for the patch -- it does improve the error handling!
 
Acked-by: Dexuan Cui <decui@microsoft.com>

-- Dexuan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/