Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752853AbaKKI5B (ORCPT <rfc822;w@1wt.eu>);
	Tue, 11 Nov 2014 03:57:01 -0500
Received: from a.ns.miles-group.at ([95.130.255.143]:65275 "EHLO radon.swed.at"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752124AbaKKI47 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Nov 2014 03:56:59 -0500
Message-ID: <5461CF56.5010407@nod.at>
Date: Tue, 11 Nov 2014 09:56:54 +0100
From: Richard Weinberger <richard@nod.at>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
To: Joe Perches <joe@perches.com>, Tanya Brokhman <tlinder@codeaurora.org>
CC: dedekind1@gmail.com, linux-mtd@lists.infradead.org,
        linux-arm-msm@vger.kernel.org,
        Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities
References: <1415023112-21704-1-git-send-email-tlinder@codeaurora.org>	 <5460F7D8.2030100@nod.at> <1415642273.8868.8.camel@perches.com>	 <5461C7C6.6060604@codeaurora.org> <1415694886.16070.3.camel@perches.com>
In-Reply-To: <1415694886.16070.3.camel@perches.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Am 11.11.2014 um 09:34 schrieb Joe Perches:
> On Tue, 2014-11-11 at 10:24 +0200, Tanya Brokhman wrote:
>> On 11/10/2014 7:57 PM, Joe Perches wrote:
>>> On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote:
>>>> Am 03.11.2014 um 14:58 schrieb Tanya Brokhman:
>>>>> If there is more then one UBI device mounted, there is no way to
>>>>> distinguish between messages from different UBI devices.
>>>>> Add device number to all ubi layer message types.
>>>
>>> Adding "error" and "warning" to the message logs is
>>> duplicative to the KERN_<LEVEL> logging information.
>>>
>>>>> Changes from V5:
>>>>> 	- Added ptr verification @ ubi_err/ubi_msg/ubi_warn
>>>>> 	Removed extra printing of ubi number
>>>>> 	Removed new messages.
>>>
>>> Did you all ever look at what I posted?
>>
>> I did. Its not my place to re-post your change in my patch. I personally 
>> prefer it the way I've done it but it's just a matter of opinion and 
>> personal preference.
> 
> Don't forget object code size.

That's a good point.
Tanya's patch is already in linux-ubifs.git (http://git.infradead.org/linux-ubifs.git).
Later we could patch ubi.h to use Joe's log functions.

But first I'd like to fix the logging style.
I'm really unhappy with it.

The patch does much more that the commit messages says:
"If there is more then one UBI device mounted, there is no way to
distinguish between messages from different UBI devices.
Add device number to all ubi layer message types.

The R/O block driver messages were replaced by pr_* since
ubi_device structure is not used by it."

There is no hint that it adds the function name to every log message.
If so, I'd have nack'ed the patch.

Thanks,
//richard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/