Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752416AbaKKLYc (ORCPT ); Tue, 11 Nov 2014 06:24:32 -0500 Received: from foss-mx-na.foss.arm.com ([217.140.108.86]:55997 "EHLO foss-mx-na.foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751119AbaKKLYa (ORCPT ); Tue, 11 Nov 2014 06:24:30 -0500 Date: Tue, 11 Nov 2014 11:24:24 +0000 From: Will Deacon To: "suravee.suthikulpanit@amd.com" Cc: "bhelgaas@google.com" , Liviu Dudau , Lorenzo Pieralisi , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] PCI: generic: Add set_msi_parent callback Message-ID: <20141111112424.GB16265@arm.com> References: <1415647480-3320-1-git-send-email-suravee.suthikulpanit@amd.com> <1415647480-3320-3-git-send-email-suravee.suthikulpanit@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1415647480-3320-3-git-send-email-suravee.suthikulpanit@amd.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Suravee, On Mon, Nov 10, 2014 at 07:24:40PM +0000, suravee.suthikulpanit@amd.com wrote: > From: Suravee Suthikulpanit > > This patch implement set_msi_parent callback for PCI generic host controller. > > Cc: Bjorn Helgass > Cc: Liviu Dudau > Cc: Lorenzo Pieralisi > Signed-off-by: Suravee Suthikulpanit > --- > drivers/pci/host/pci-host-generic.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/pci/host/pci-host-generic.c b/drivers/pci/host/pci-host-generic.c > index 036ab1b..f9bb97a 100644 > --- a/drivers/pci/host/pci-host-generic.c > +++ b/drivers/pci/host/pci-host-generic.c > @@ -42,6 +42,7 @@ struct gen_pci { > struct pci_host_bridge host; > struct gen_pci_cfg_windows cfg; > struct list_head resources; > + struct msi_chip *mchip; > }; > > #ifdef CONFIG_ARM > @@ -128,9 +129,19 @@ static int gen_pci_config_write(struct pci_bus *bus, unsigned int devfn, > return PCIBIOS_SUCCESSFUL; > } > > +static int gen_pci_set_msi_parent(struct pci_bus *bus) > +{ > + struct gen_pci *pci = bus_to_gen_pci(bus); > + > + bus->msi = pci->mchip; > + > + return PCIBIOS_SUCCESSFUL; > +} I don't think this makes much sense a host controller callback. Why can't bus->msi be set in generic code? > static struct pci_ops gen_pci_ops = { > .read = gen_pci_config_read, > .write = gen_pci_config_write, > + .set_msi_parent = gen_pci_set_msi_parent, > }; > > static const struct of_device_id gen_pci_of_match[] = { > @@ -313,6 +324,9 @@ static int gen_pci_probe(struct platform_device *pdev) > return err; > } > > + pci->mchip = of_pci_find_msi_chip_by_node(of_parse_phandle(np, > + "msi-parent", 0)); This bit should be in the generic of_pci.c code and not duplicated for each host controller. Will -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/