Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754148AbaKKLob (ORCPT <rfc822;w@1wt.eu>);
	Tue, 11 Nov 2014 06:44:31 -0500
Received: from mga14.intel.com ([192.55.52.115]:12089 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1754070AbaKKLoJ (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Tue, 11 Nov 2014 06:44:09 -0500
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.07,360,1413270000"; 
   d="scan'208";a="620509246"
Message-ID: <1415706244.22887.156.camel@sauron.fi.intel.com>
Subject: Re: [PATCH V6] UBI: Extend UBI layer debug/messaging capabilities
From: Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind1@gmail.com
To: Joe Perches <joe@perches.com>
Cc: Richard Weinberger <richard@nod.at>,
        Tanya Brokhman <tlinder@codeaurora.org>, linux-mtd@lists.infradead.org,
        linux-arm-msm@vger.kernel.org, David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
Date: Tue, 11 Nov 2014 13:44:04 +0200
In-Reply-To: <1415642273.8868.8.camel@perches.com>
References: <1415023112-21704-1-git-send-email-tlinder@codeaurora.org>
	 <5460F7D8.2030100@nod.at> <1415642273.8868.8.camel@perches.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.10.4 (3.10.4-4.fc20) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, 2014-11-10 at 09:57 -0800, Joe Perches wrote:
> On Mon, 2014-11-10 at 18:37 +0100, Richard Weinberger wrote:
> > Am 03.11.2014 um 14:58 schrieb Tanya Brokhman:
> > > If there is more then one UBI device mounted, there is no way to
> > > distinguish between messages from different UBI devices.
> > > Add device number to all ubi layer message types.
> 
> Adding "error" and "warning" to the message logs is
> duplicative to the KERN_<LEVEL> logging information.
> 
> > > Changes from V5:
> > > 	- Added ptr verification @ ubi_err/ubi_msg/ubi_warn
> > > 	Removed extra printing of ubi number
> > > 	Removed new messages.
> 
> Did you all ever look at what I posted?
> 
> https://lkml.org/lkml/2014/10/14/280
> 
> smaller code, consistent prefixing, consistent with
> typical kernel style, etc.

No, I did not, because Tanya is someone who actually using and
developing that stuff, and you are more of being on the watch for the
kernel in general. So naturally, I use my limited time to first check
her stuff. Sorry for this.

But Let me change small things in Tanya's patch first. The if you'd be
kind enough to implement your changes on top of that, that'd be perfect.

Artem.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/