Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752276AbaKLLhc (ORCPT ); Wed, 12 Nov 2014 06:37:32 -0500 Received: from [207.46.100.124] ([207.46.100.124]:48304 "EHLO na01-by2-obe.outbound.protection.outlook.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751954AbaKLLh3 (ORCPT ); Wed, 12 Nov 2014 06:37:29 -0500 X-WSS-ID: 0NEXCA2-07-9MU-02 X-M-MSG: Message-ID: <54634665.5030003@amd.com> Date: Wed, 12 Nov 2014 18:37:09 +0700 From: Suravee Suthikulpanit User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Srikanth Thokala CC: Bjorn Helgaas , , , , "linux-pci@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 2/2] PCI: generic: Add msi_parent DT binding References: <1415733454-24322-1-git-send-email-suravee.suthikulpanit@amd.com> <1415733454-24322-3-git-send-email-suravee.suthikulpanit@amd.com> In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.180.168.240] X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.221;CTRY:US;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(428002)(51704005)(199003)(189002)(24454002)(51914003)(479174003)(46102003)(99396003)(83506001)(50466002)(76176999)(64706001)(54356999)(65956001)(20776003)(47776003)(87266999)(65816999)(31966008)(65806001)(68736004)(120916001)(23676002)(50986999)(44976005)(99136001)(84676001)(97736003)(110136001)(77156002)(77096003)(62966003)(92726001)(4396001)(92566001)(117636001)(59896002)(102836001)(106466001)(64126003)(105586002)(107046002)(95666004)(86362001)(21056001)(87936001)(36756003)(93886004)(101416001)(41533002)(62816006);DIR:OUT;SFP:1102;SCL:1;SRVR:BN1PR02MB200;H:atltwp01.amd.com;FPR:;MLV:sfv;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Antispam: UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB200; X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB200; X-Forefront-PRVS: 03932714EB Authentication-Results: spf=none (sender IP is 165.204.84.221) smtp.mailfrom=Suravee.Suthikulpanit@amd.com; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:;SRVR:BN1PR02MB200; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 11/12/14 14:09, Srikanth Thokala wrote: >>> @@ -122,9 +123,19 @@ static int gen_pci_config_write(struct pci_bus *bus, unsigned int devfn, >>> >> return PCIBIOS_SUCCESSFUL; >>> >> } >>> >> >>> >>+static int gen_pci_set_msi_parent(struct pci_bus *bus) >>> >>+{ >>> >>+ struct gen_pci *pci = bus_to_gen_pci(bus); >>> >>+ >>> >>+ bus->msi = pci->mchip; >>> >>+ >>> >>+ return PCIBIOS_SUCCESSFUL; >>> >>+} >>> >>+ >>> >> static struct pci_ops gen_pci_ops = { >>> >> .read = gen_pci_config_read, >>> >> .write = gen_pci_config_write, >>> >>+ .set_msi_parent = gen_pci_set_msi_parent, >> > >> >We assign the msi chip through add_bus() call, do we still need this? >> > > There are series of patches from Yijing Wang around this. You may have > to go through them. > > Srikanth > Hm.. I was not aware of this patch. Thanks for the pointer. I'll check them out. Suravee -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/