Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752709AbaKLM1N (ORCPT ); Wed, 12 Nov 2014 07:27:13 -0500 Received: from mail.us.es ([193.147.175.20]:37068 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611AbaKLM1H (ORCPT ); Wed, 12 Nov 2014 07:27:07 -0500 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus3 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.98.4/19617. spamassassin: 3.3.2. Clear:RC:1(127.0.0.1):SA:0(-103.2/7.5):. Processed in 5.001428 secs); 12 Nov 2014 12:27:06 -0000 X-Spam-ASN: AS12715 87.216.0.0/16 X-Envelope-From: pneira@us.es Date: Wed, 12 Nov 2014 13:29:00 +0100 From: Pablo Neira Ayuso To: Petr Mladek Cc: Joe Perches , Steven Rostedt , Corey Minyard , Alexander Viro , Patrick McHardy , Jozsef Kadlecsik , "David S. Miller" , Alexey Kuznetsov , James Morris , Hideaki YOSHIFUJI , openipmi-developer@lists.sourceforge.net, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org Subject: Re: [PATCH -next 2/2] seq_putc: Convert to return void and convert uses too. Message-ID: <20141112122900.GA1542@salvia> References: <56c4c0d5ec721134cff4913e5e3f8923169c35ef.1415645477.git.joe@perches.com> <20141111134740.GB2567@pathway.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20141111134740.GB2567@pathway.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 11, 2014 at 02:47:40PM +0100, Petr Mladek wrote: > On Mon 2014-11-10 10:58:57, Joe Perches wrote: > > Using the return value of seq_putc is error-prone, so > > make it return void instead. > > > > Reverse the logic in seq_putc to make it like seq_puts. > > > > Signed-off-by: Joe Perches > > Reviewed-by: Petr Mladek > > The changes are correct. The show() functions should return 0 > even when there is an overflow. They are called by traverse() > from seq_read() that might increase the buffer size and try again. Just in case you need this for the netfilter chunks: Acked-by: Pablo Neira Ayuso Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/