Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752876AbaKLOUi (ORCPT ); Wed, 12 Nov 2014 09:20:38 -0500 Received: from gum.cmpxchg.org ([85.214.110.215]:58909 "EHLO gum.cmpxchg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752190AbaKLOUh (ORCPT ); Wed, 12 Nov 2014 09:20:37 -0500 Date: Wed, 12 Nov 2014 09:20:22 -0500 From: Johannes Weiner To: Weijie Yang Cc: "'Andrew Morton'" , mgorman@suse.de, "'Rik van Riel'" , "'Weijie Yang'" , "'Linux-MM'" , "'linux-kernel'" Subject: Re: [PATCH] mm: mincore: add hwpoison page handle Message-ID: <20141112142022.GA29766@phnom.home.cmpxchg.org> References: <000001cffe2a$66a95a50$33fc0ef0$%yang@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <000001cffe2a$66a95a50$33fc0ef0$%yang@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 12, 2014 at 11:39:29AM +0800, Weijie Yang wrote: > When encounter pte is a swap entry, the current code handles two cases: > migration and normal swapentry, but we have a third case: hwpoison page. > > This patch adds hwpoison page handle, consider hwpoison page incore as > same as migration. > > Signed-off-by: Weijie Yang The change makes sense: Acked-by: Johannes Weiner But please add a description of what happens when a poison entry is encountered with the current code. I'm guessing swap_address_space() will return garbage and this might crash the kernel? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/