Message-ID: <5463BFE2.4000404@ezchip.com>
Date: Wed, 12 Nov 2014 15:15:30 -0500
From: Chris Metcalf <cmetcalf@ezchip.com>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0
MIME-Version: 1.0
To: Chen Gang <gang.chen.5i5j@gmail.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        <jepler@unpythonic.net>
Subject: Re: [PATCH] arch: tile: kernel: kgdb.c: Use memcpy() instead of pointer
 copy one by one
References: <5454DD70.6060004@gmail.com> <5462C1D3.3010504@gmail.com>
In-Reply-To: <5462C1D3.3010504@gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On 11/1/14 21:17, Chen Gang wrote:
> >Not only memcpy() is faster than pointer copy, but also let code more
> >clearer and simple, which can avoid compiling warning (the original
> >implementation copy registers by exceeding member array border).
> >
> >The related warning (with allmodconfig under tile):
> >
> >     CC      arch/tile/kernel/kgdb.o
> >   arch/tile/kernel/kgdb.c: In function 'sleeping_thread_to_gdb_regs':
> >   arch/tile/kernel/kgdb.c:140:31: warning: iteration 53u invokes undefined behavior [-Waggressive-loop-optimizations]
> >      *(ptr++) = thread_regs->regs[reg];
> >                                  ^
> >   arch/tile/kernel/kgdb.c:139:2: note: containing loop
> >     for (reg = 0; reg <= TREG_LAST_GPR; reg++)
> >     ^
> >
> >Signed-off-by: Chen Gang<gang.chen.5i5j@gmail.com>
> >---
> >  arch/tile/kernel/kgdb.c | 6 +-----
> >  1 file changed, 1 insertion(+), 5 deletions(-)
> >

Taken into the tile tree - thanks!

See my recent email about changing the shape of the pt_regs and sigcontext
structures to make the regs[] usage explicit.  But even with that, I
think your change makes sense to simplify the code in this location.

-- 
Chris Metcalf, EZChip Semiconductor
http://www.ezchip.com

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/