Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752830AbaKLVtV (ORCPT ); Wed, 12 Nov 2014 16:49:21 -0500 Received: from mail-vc0-f182.google.com ([209.85.220.182]:52846 "EHLO mail-vc0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751942AbaKLVtU (ORCPT ); Wed, 12 Nov 2014 16:49:20 -0500 MIME-Version: 1.0 In-Reply-To: <20141112213845.GA14153@dtor-ws> References: <20141112213845.GA14153@dtor-ws> Date: Wed, 12 Nov 2014 13:49:18 -0800 X-Google-Sender-Auth: jLppc3PXpDsXT6IZkARD49MSbRI Message-ID: Subject: Re: [PATCH] clk: rockchip: ensure HCLK_VIO2_H2P and PCLK_VIO2_H2P stay enabled From: Doug Anderson To: Dmitry Torokhov Cc: Heiko Stuebner , Mike Turquette , Jianqun , Kever Yang , Mark yao , "linux-arm-kernel@lists.infradead.org" , "open list:ARM/Rockchip SoC..." , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Wed, Nov 12, 2014 at 1:38 PM, Dmitry Torokhov wrote: > Currently there is no driver owning these clocks and they have to stay > up for the system to function properly, so let's mark them as > CLK_IGNORE_UNUSED. > > Without this patch we have trouble with suspend/resume and we have > trouble turning the eDP back on if it ever idles off. > > Signed-off-by: Doug Anderson > Signed-off-by: Dmitry Torokhov > --- > drivers/clk/rockchip/clk-rk3288.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) I'm already on the signed-off-by (mostly because I tweaked the commit message and tested this), but in case anyone cares I have reviewed this and tested it. ;) ...obviously we want to get to the bottom of the right way to handle all of these clocks, but since we _just_ removed the blanket "leave all clocks enabled" adding a few clocks back into the fold seems sane until we get all our ducks in a row. Reviewed-by: Doug Anderson Tested-by: Doug Anderson -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/