From: Weijie Yang <weijie.yang@samsung.com>
To: "'Mahendran Ganesh'" <opensource.ganesh@gmail.com>
Cc: "'Minchan Kim'" <minchan@kernel.org>, ngupta@vflare.org,
        sergey.senozhatsky@gmail.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org
References: <1415803038-7913-1-git-send-email-opensource.ganesh@gmail.com>
 <20141113000216.GA1074@bbox>
In-reply-to: <20141113000216.GA1074@bbox>
Subject: RE: [PATCH] mm/zram: correct ZRAM_ZERO flag bit position
Date: Thu, 13 Nov 2014 09:27:33 +0800
Message-id: <000001cffee1$28362ed0$78a28c70$%yang@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=utf-8
Content-transfer-encoding: 7bit
Thread-index: Ac/+1Q+V64BeicsdT/qZxTcfBwh5IgAC5yRQ
Content-language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org

On Thu, Nov 13, 2014 at 8:02 AM, Minchan Kim <minchan@kernel.org> wrote:
> On Wed, Nov 12, 2014 at 10:37:18PM +0800, Mahendran Ganesh wrote:
>> In struct zram_table_entry, the element *value* contains obj size and
>> obj zram flags. Bit 0 to bit (ZRAM_FLAG_SHIFT - 1) represent obj size,
>> and bit ZRAM_FLAG_SHIFT to the highest bit of unsigned long represent obj
>> zram_flags. So the first zram flag(ZRAM_ZERO) should be from ZRAM_FLAG_SHIFT
>> instead of (ZRAM_FLAG_SHIFT + 1).
>>
>> This patch fixes this issue.
>>
>> Also this patch fixes a typo, "page in now accessed" -> "page is now accessed"
>>
>> Signed-off-by: Mahendran Ganesh <opensource.ganesh@gmail.com>
> Acked-by: Minchan Kim <minchan@kernel.org>

Acked-by: Weijie Yang <weijie.yang@samsung.com>

> To be clear about "fixes this issue", it's not a bug but just clean up
> so it doesn't change any behavior.
>
> Thanks!
>
> --
> Kind regards,
> Minchan Kim
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/