Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753654AbaKMB4M (ORCPT ); Wed, 12 Nov 2014 20:56:12 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:39724 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753454AbaKMB4J (ORCPT ); Wed, 12 Nov 2014 20:56:09 -0500 MIME-Version: 1.0 In-Reply-To: <20141112123232.GE6759@red-moon> References: <1415702040-2790-1-git-send-email-ming.lei@canonical.com> <20141111122901.GA4419@red-moon> <20141111182418.GA5507@red-moon> <20141112095846.GA6759@red-moon> <20141112123232.GE6759@red-moon> Date: Thu, 13 Nov 2014 09:56:06 +0800 Message-ID: Subject: Re: [PATCH] pci: generic host: make it more generic From: Ming Lei To: Lorenzo Pieralisi Cc: Bjorn Helgaas , Will Deacon , "linux-kernel@vger.kernel.org" , "linux-pci@vger.kernel.org" , Rob Herring , alvise rigo Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 12, 2014 at 8:32 PM, Lorenzo Pieralisi wrote: > On Wed, Nov 12, 2014 at 10:51:31AM +0000, Ming Lei wrote: >> On Wed, Nov 12, 2014 at 5:58 PM, Lorenzo Pieralisi >> wrote: >> > On Wed, Nov 12, 2014 at 02:12:12AM +0000, Ming Lei wrote: >> >> On Wed, Nov 12, 2014 at 2:24 AM, Lorenzo Pieralisi >> >> wrote: >> >> > On Tue, Nov 11, 2014 at 02:02:20PM +0000, Ming Lei wrote: >> >> > >> >> > [...] >> >> > >> >> >> > http://lists.infradead.org/pipermail/linux-arm-kernel/2014-October/296535.html >> >> >> > >> >> >> > Patch above is already queued and applies most of the changes you have posted >> >> >> > above. >> >> >> >> >> >> I should have looked at list first before writing the patch, :-( >> >> >> >> >> >> Could you make it more generic so that other ARCHs(at least ARM64) >> >> >> can benefit from it too? >> >> > >> >> > That's our current goal, we are carrying out clean-ups to remove arch >> >> > dependency and move code to the generic layer PCI layer. >> >> >> >> OK, I am glad to test them after you post them out. >> >> >> >> At least, the 'struct gen_pci' pointer can be put in driver data >> >> of the platform_device now, which may remove dependency on >> >> pci_sysdata in this driver. But ARCH's pcibios code still may >> >> access 'pci_sysdata', do you have patches or solution to handle >> >> this issue? >> > >> > I will consider adding struct gen_pci pointer as platform device >> > driver data, we are working on removing pci_sys_data dependency in the ARM >> > pcibios backend, and I do not think we are far from achieving that. >> >> Other ARCHs has sort of pcibios backend too, so that said it still >> depends on ARM or ARM64, doesn't it? > > Yes, so ? If you think there is a way to make this host controller work I mean suppose the driver/device is only for ARM and ARM64, it should be easy to support, and it may not be necessary to remove pci_sys_data dependency in the ARM, such as: - make a different code path for ARM64 - or like this patch to fake sysdata for ARM - or what ever > on all arches you fancy using it on with no arch dependency in a proper > way step up to the plate and post the code, we will duly review it. The only way I thought of is to bypass pcibios handling for the generic host controller, but it may not be agreed. Thanks, Ming Lei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/