Message-ID: <1415884083.14686.439.camel@mfleming-mobl1.ger.corp.intel.com>
Subject: Re: BUG() at boot in __phys_addr with DEBUG_VIRTUAL
From: Matt Fleming <matt.fleming@intel.com>
To: Dave Hansen <dave.hansen@intel.com>
CC: Borislav Petkov <bp@suse.de>, the arch/x86 maintainers <x86@kernel.org>,
        LKML <linux-kernel@vger.kernel.org>
Date: Thu, 13 Nov 2014 13:08:03 +0000
In-Reply-To: <54637AD5.6060300@intel.com>
References: <5462999A.7090706@intel.com>
	 <1415784298.14686.323.camel@mfleming-mobl1.ger.corp.intel.com>
	 <54637576.7030004@intel.com> <20141112151106.GB17793@pd.tnic>
	 <54637AD5.6060300@intel.com>
Organization: Intel Corporation (UK) Ltd. - Registered No. 1134945 - Pipers
 Way, Swindon SN3 1RJ
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org

On Wed, 2014-11-12 at 07:20 -0800, Dave Hansen wrote:
> 
> The path that we're actually hitting this from is:
> 
> > __split_large_page(struct cpa_data *cpa, pte_t *kpte, unsigned long
> ...
> >         if (pfn_range_is_mapped(PFN_DOWN(__pa(address)),
> >                                 PFN_DOWN(__pa(address)) + 1))
> >                 split_page_count(level);

I'm sure I'm just being dumb, but I can't for the life of me work out
why we need to calculate the physical address from the virtual address
at this point - we should already have that information.

> So perhaps efi_map_region() is handing an address from the EFI identity
> map down in here.  __pa() gets called on it, but that fails since __pa()
> only works on the *KERNEL* identity map.

Yep, sounds right.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/