Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933315AbaKMOQM (ORCPT ); Thu, 13 Nov 2014 09:16:12 -0500 Received: from mail-oi0-f42.google.com ([209.85.218.42]:57924 "EHLO mail-oi0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932910AbaKMOQL (ORCPT ); Thu, 13 Nov 2014 09:16:11 -0500 MIME-Version: 1.0 In-Reply-To: <20141113025544.GB9068@medulla.variantweb.net> References: <1415535832-4822-1-git-send-email-opensource.ganesh@gmail.com> <20141113025544.GB9068@medulla.variantweb.net> Date: Thu, 13 Nov 2014 22:16:10 +0800 Message-ID: Subject: Re: [PATCH] mm/zswap: add __init to some functions in zswap From: Ganesh Mahendran To: Seth Jennings Cc: Minchan Kim , ddstreet@ieee.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2014-11-13 10:55 GMT+08:00 Seth Jennings : > On Sun, Nov 09, 2014 at 08:23:52PM +0800, Mahendran Ganesh wrote: >> zswap_cpu_init/zswap_comp_exit/zswap_entry_cache_create is only >> called by __init init_zswap() > > Thanks for the cleanup! > > Acked-by: Seth Jennings Thanks very much! > >> >> Signed-off-by: Mahendran Ganesh >> --- >> mm/zswap.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/mm/zswap.c b/mm/zswap.c >> index 51a2c45..2e621fa 100644 >> --- a/mm/zswap.c >> +++ b/mm/zswap.c >> @@ -149,7 +149,7 @@ static int __init zswap_comp_init(void) >> return 0; >> } >> >> -static void zswap_comp_exit(void) >> +static void __init zswap_comp_exit(void) >> { >> /* free percpu transforms */ >> if (zswap_comp_pcpu_tfms) >> @@ -206,7 +206,7 @@ static struct zswap_tree *zswap_trees[MAX_SWAPFILES]; >> **********************************/ >> static struct kmem_cache *zswap_entry_cache; >> >> -static int zswap_entry_cache_create(void) >> +static int __init zswap_entry_cache_create(void) >> { >> zswap_entry_cache = KMEM_CACHE(zswap_entry, 0); >> return zswap_entry_cache == NULL; >> @@ -389,7 +389,7 @@ static struct notifier_block zswap_cpu_notifier_block = { >> .notifier_call = zswap_cpu_notifier >> }; >> >> -static int zswap_cpu_init(void) >> +static int __init zswap_cpu_init(void) >> { >> unsigned long cpu; >> >> -- >> 1.7.9.5 >> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/