Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753977AbaKMOxt (ORCPT ); Thu, 13 Nov 2014 09:53:49 -0500 Received: from down.free-electrons.com ([37.187.137.238]:40837 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753948AbaKMOxs (ORCPT ); Thu, 13 Nov 2014 09:53:48 -0500 Date: Thu, 13 Nov 2014 15:53:43 +0100 From: Boris Brezillon To: Nicolas Ferre Cc: Alexandre Belloni , "Sebastian Reichel" , Jean-Christophe Plagniol-Villard , "Dmitry Eremin-Solenikov" , Maxime Ripard , , , , Arnd Bergmann , Olof Johansson , Kevin Hilman Subject: Re: [PATCH] ARM: at91: move sdramc/ddrsdr header to include/soc/at91 Message-ID: <20141113155343.5c92c2d6@bbrezillon> In-Reply-To: <54649221.9060307@atmel.com> References: <1415393901-18469-1-git-send-email-alexandre.belloni@free-electrons.com> <54649221.9060307@atmel.com> X-Mailer: Claws Mail 3.9.3 (GTK+ 2.24.23; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Nov 2014 12:12:33 +0100 Nicolas Ferre wrote: > On 07/11/2014 21:58, Alexandre Belloni : > > Move the (DDR) SDRAM controller headers to include/soc/at91 to remove the > > dependency on mach/ headers from the at91-reset driver. > > > > Signed-off-by: Alexandre Belloni > > --- > > As my previous attempts were not popular, solve the mach/ headers issue by > > simply moving them. I'll get back to better driver separation when it will be > > possible to map the SRAM as executable memory. > > > > MAINTAINERS | 1 + > > arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +- > > .../arm/mach-at91/include/mach/at91rm9200_sdramc.h | 63 ----------- > > arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h | 124 --------------------- > > arch/arm/mach-at91/include/mach/at91sam9_sdramc.h | 85 -------------- > > arch/arm/mach-at91/pm.h | 1 - > > drivers/power/reset/at91-reset.c | 4 +- > > include/soc/at91/at91rm9200_sdramc.h | 63 +++++++++++ > > include/soc/at91/at91sam9_ddrsdr.h | 124 +++++++++++++++++++++ > > include/soc/at91/at91sam9_sdramc.h | 85 ++++++++++++++ > > 10 files changed, 278 insertions(+), 278 deletions(-) > > delete mode 100644 arch/arm/mach-at91/include/mach/at91rm9200_sdramc.h > > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_ddrsdr.h > > delete mode 100644 arch/arm/mach-at91/include/mach/at91sam9_sdramc.h > > create mode 100644 include/soc/at91/at91rm9200_sdramc.h > > create mode 100644 include/soc/at91/at91sam9_ddrsdr.h > > create mode 100644 include/soc/at91/at91sam9_sdramc.h > > This would have been cleaner and easier to understand with > git format-patch -M > > --8<-------------------------------- > MAINTAINERS | 1 + > arch/arm/mach-at91/include/mach/at91_ramc.h | 6 +++--- > arch/arm/mach-at91/pm.h | 1 - > drivers/power/reset/at91-reset.c | 4 ++-- > .../mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h | 0 > .../mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h | 0 > .../mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h | 0 > 7 files changed, 6 insertions(+), 6 deletions(-) > rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91rm9200_sdramc.h (100%) > rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_ddrsdr.h (100%) > rename {arch/arm/mach-at91/include/mach => include/soc/at91}/at91sam9_sdramc.h (100%) > --8<-------------------------------- > > Acked-by: Nicolas Ferre > > and queued for at91-3.19-cleanup I'm getting back to this patch because I'd like understand what exactly should be put in include/soc/ and what should be put in the subsystem directory (include/linux/) ? Regards, Boris -- Boris Brezillon, Free Electrons Embedded Linux and Kernel engineering http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/