Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934140AbaKMUrj (ORCPT ); Thu, 13 Nov 2014 15:47:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:53687 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932767AbaKMUrh convert rfc822-to-8bit (ORCPT ); Thu, 13 Nov 2014 15:47:37 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <1415906662-4576-17-git-send-email-bobby.prani@gmail.com> References: <1415906662-4576-17-git-send-email-bobby.prani@gmail.com> <1415906662-4576-1-git-send-email-bobby.prani@gmail.com> To: Pranith Kumar Cc: dhowells@redhat.com, "David S. Miller" , Dan Carpenter , netdev@vger.kernel.org (open list:NETWORKING [GENERAL]), linux-kernel@vger.kernel.org (open list), paulmck@linux.vnet.ibm.com Subject: Re: [PATCH 16/16] rxrpc: Replace smp_read_barrier_depends() with lockless_dereference() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <24600.1415911646.1@warthog.procyon.org.uk> Content-Transfer-Encoding: 8BIT Date: Thu, 13 Nov 2014 20:47:26 +0000 Message-ID: <24601.1415911646@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Pranith Kumar wrote: > Recently lockless_dereference() was added which can be used in place of > hard-coding smp_read_barrier_depends(). The following PATCH makes the change. Actually, the use of smp_read_barrier_depends() is wrong in circular buffering. See Documentation/circular-buffers.txt David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/