Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934895AbaKMVlV (ORCPT ); Thu, 13 Nov 2014 16:41:21 -0500 Received: from mail-oi0-f41.google.com ([209.85.218.41]:42026 "EHLO mail-oi0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934734AbaKMVlR (ORCPT ); Thu, 13 Nov 2014 16:41:17 -0500 MIME-Version: 1.0 In-Reply-To: References: Date: Thu, 13 Nov 2014 13:41:16 -0800 X-Google-Sender-Auth: hxOv-1K-oBaMbh2JculxcyHqINo Message-ID: Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup From: Benson Leung To: Alan Stern Cc: johan@kernel.org, Jiri Kosina , linux-usb@vger.kernel.org, "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sameer Nanda Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 13, 2014 at 1:18 PM, Alan Stern wrote: > If you interchange the two lines then the flag _will_ be cleared before > usb_kill_urb() and autosuspend_check() can run. This means your patch > description is bogus. Gotcha. v2 posted. Thanks for the direction. -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/