Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934527AbaKMWLS (ORCPT ); Thu, 13 Nov 2014 17:11:18 -0500 Received: from iolanthe.rowland.org ([192.131.102.54]:47661 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S933765AbaKMWLQ (ORCPT ); Thu, 13 Nov 2014 17:11:16 -0500 Date: Thu, 13 Nov 2014 17:11:15 -0500 (EST) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Benson Leung cc: johan@kernel.org, Jiri Kosina , , "linux-input@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Sameer Nanda Subject: Re: [PATCH] HID: usbhid: get/put around clearing needs_remote_wakeup In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 13 Nov 2014, Benson Leung wrote: > On Thu, Nov 13, 2014 at 1:18 PM, Alan Stern wrote: > > If you interchange the two lines then the flag _will_ be cleared before > > usb_kill_urb() and autosuspend_check() can run. This means your patch > > description is bogus. > > Gotcha. v2 posted. Thanks for the direction. Wait a minute -- in your previous email you said this approach didn't work. So does it work or doesn't it? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/