Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752753AbaKNFYo (ORCPT ); Fri, 14 Nov 2014 00:24:44 -0500 Received: from e23smtp08.au.ibm.com ([202.81.31.141]:57933 "EHLO e23smtp08.au.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751146AbaKNFYm (ORCPT ); Fri, 14 Nov 2014 00:24:42 -0500 Date: Fri, 14 Nov 2014 10:54:28 +0530 From: Srikar Dronamraju To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andrew Morton , Jiri Kosina , Petr Mladek , Masami Hiramatsu Subject: Re: [RFC][PATCH 07/23 v4] kprobes/tracing: Use trace_seq_has_overflowed() for overflow checks Message-ID: <20141114052428.GB336@linux.vnet.ibm.com> Reply-To: Srikar Dronamraju References: <20141114011244.256115061@goodmis.org> <20141114011411.181812785@goodmis.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <20141114011411.181812785@goodmis.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14111405-0029-0000-0000-000000983D6B Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Steven Rostedt [2014-11-13 20:12:51]: > From: "Steven Rostedt (Red Hat)" > > Instead of checking the return value of trace_seq_printf() and friends > for overflowing of the buffer, use the trace_seq_has_overflowed() helper > function. > > This cleans up the code quite a bit and also takes us a step closer to > changing the return values of trace_seq_printf() and friends to void. > > Cc: Masami Hiramatsu > Signed-off-by: Steven Rostedt Looks good me to me. Reviewed-by: Srikar Dronamraju -- Thanks and Regards Srikar Dronamraju -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/